[
https://issues.apache.org/jira/browse/HIVE-22888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042232#comment-17042232
]
Hive QA commented on HIVE-22888:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12994118/HIVE-22888.4.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 17 failed/errored test(s), 17907 tests
executed
*Failed tests:*
{noformat}
TestCommandProcessorFactory - did not produce a TEST-*.xml file (likely timed
out) (batchId=361)
TestDbTxnManager - did not produce a TEST-*.xml file (likely timed out)
(batchId=361)
TestDummyTxnManager - did not produce a TEST-*.xml file (likely timed out)
(batchId=361)
TestEmbeddedLockManager - did not produce a TEST-*.xml file (likely timed out)
(batchId=361)
TestGetInputSummary - did not produce a TEST-*.xml file (likely timed out)
(batchId=342)
TestHiveCredentialProviders - did not produce a TEST-*.xml file (likely timed
out) (batchId=342)
TestHiveInputSplitComparator - did not produce a TEST-*.xml file (likely timed
out) (batchId=361)
TestHiveLockObject - did not produce a TEST-*.xml file (likely timed out)
(batchId=361)
TestKeyWrapperFactory - did not produce a TEST-*.xml file (likely timed out)
(batchId=342)
TestLog4j2Appenders - did not produce a TEST-*.xml file (likely timed out)
(batchId=342)
TestResetProcessor - did not produce a TEST-*.xml file (likely timed out)
(batchId=361)
TestSetProcessor - did not produce a TEST-*.xml file (likely timed out)
(batchId=361)
TestSlidingFilenameRolloverStrategy - did not produce a TEST-*.xml file (likely
timed out) (batchId=342)
TestSyslogInputFormat - did not produce a TEST-*.xml file (likely timed out)
(batchId=342)
TestTxnCommands - did not produce a TEST-*.xml file (likely timed out)
(batchId=361)
TestTxnCommandsWithSplitUpdateAndVectorization - did not produce a TEST-*.xml
file (likely timed out) (batchId=342)
TestZookeeperLockManager - did not produce a TEST-*.xml file (likely timed out)
(batchId=361)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20775/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20775/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20775/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 17 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12994118 - PreCommit-HIVE-Build
> Rewrite checkLock inner select with JOIN operator
> -------------------------------------------------
>
> Key: HIVE-22888
> URL: https://issues.apache.org/jira/browse/HIVE-22888
> Project: Hive
> Issue Type: Improvement
> Components: Locking
> Reporter: Denys Kuzmenko
> Assignee: Denys Kuzmenko
> Priority: Major
> Attachments: HIVE-22888.1.patch, HIVE-22888.2.patch,
> HIVE-22888.3.patch, HIVE-22888.4.patch
>
>
> - Created extra (db, tbl, part) index on HIVE_LOCKS table;
> - Replaced inner select under checkLocks using multiple IN statements with
> JOIN operator;
> generated query looks like :
> {code}
> SELECT LS.* FROM (
> SELECT HL_LOCK_EXT_ID, HL_DB, HL_TABLE, HL_PARTITION, HL_LOCK_STATE,
> HL_LOCK_TYPE FROM HIVE_LOCKS
> WHERE HL_LOCK_EXT_ID < 333) LS
> INNER JOIN (
> SELECT HL_DB, HL_TABLE, HL_PARTITION, HL_LOCK_TYPE FROM HIVE_LOCKS WHERE
> HL_LOCK_EXT_ID = 333) LBC
> ON LS.HL_DB = LBC.HL_DB
> AND (LS.HL_TABLE IS NULL OR LBC.HL_TABLE IS NULL OR LS.HL_TABLE =
> LBC.HL_TABLE
> AND (LS.HL_PARTITION IS NULL OR LBC.HL_PARTITION IS NULL OR
> LS.HL_PARTITION = LBC.HL_PARTITION))
> WHERE (LBC.HL_LOCK_TYPE='e'
> AND NOT (LS.HL_TABLE IS NULL AND LS.HL_LOCK_TYPE='r' AND
> LBC.HL_TABLE IS NOT NULL )
> OR LBC.HL_LOCK_TYPE='w' AND LS.HL_LOCK_TYPE IN ('w','e')
> OR LBC.HL_LOCK_TYPE='r' AND LS.HL_LOCK_TYPE='e'
> AND NOT (LS.HL_TABLE IS NOT NULL AND LBC.HL_TABLE IS NULL))
> LIMIT 1;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
