[ https://issues.apache.org/jira/browse/HIVE-22819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042149#comment-17042149 ]
Hive QA commented on HIVE-22819: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12994095/HIVE-22819.3.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/20772/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20772/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20772/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2020-02-21 20:08:38.183 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-20772/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2020-02-21 20:08:38.186 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at c3f3523 HIVE-22744 : TezTask for the vertex with more than one outedge should have proportional sort memory (Ramesh Kumar via Ashutosh Chauhan) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at c3f3523 HIVE-22744 : TezTask for the vertex with more than one outedge should have proportional sort memory (Ramesh Kumar via Ashutosh Chauhan) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2020-02-21 20:08:39.336 + rm -rf ../yetus_PreCommit-HIVE-Build-20772 + mkdir ../yetus_PreCommit-HIVE-Build-20772 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-20772 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-20772/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch Trying to apply the patch with -p0 error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:2617 error: repository lacks the necessary blob to fall back on 3-way merge. error: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: patch does not apply Trying to apply the patch with -p1 error: src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: does not exist in index Trying to apply the patch with -p2 error: java/org/apache/hadoop/hive/ql/metadata/Hive.java: does not exist in index The patch does not appear to apply with p0, p1, or p2 + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-20772 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12994095 - PreCommit-HIVE-Build > Refactor Hive::listFilesCreatedByQuery to make it faster for object stores > -------------------------------------------------------------------------- > > Key: HIVE-22819 > URL: https://issues.apache.org/jira/browse/HIVE-22819 > Project: Hive > Issue Type: Improvement > Reporter: Marton Bod > Assignee: Marton Bod > Priority: Major > Attachments: HIVE-22819.1.patch, HIVE-22819.2.patch, > HIVE-22819.3.patch > > > {color:#0000ff}Hive::listFilesCreatedByQuery{color} does an exists(), an > isDir() and then a listing call. This can be expensive in object stores. We > should instead directly list the files in the directory (we'd have to handle > an exception if the directory does not exists, but issuing a single call to > the object store would most likely still end up being more performant). -- This message was sent by Atlassian Jira (v8.3.4#803005)