[ https://issues.apache.org/jira/browse/HIVE-22874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036367#comment-17036367 ]
Hive QA commented on HIVE-22874: -------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 52s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 0s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 28s{color} | {color:blue} jdbc in master has 16 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 31s{color} | {color:blue} beeline in master has 48 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 17m 24s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-20597/dev-support/hive-personality.sh | | git revision | master / c060c84 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | modules | C: jdbc beeline U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-20597/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Beeline unable to use credentials from URL. > ------------------------------------------- > > Key: HIVE-22874 > URL: https://issues.apache.org/jira/browse/HIVE-22874 > Project: Hive > Issue Type: Bug > Components: Beeline > Reporter: Naveen Gangam > Assignee: Naveen Gangam > Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-22874.2.patch, HIVE-22874.patch > > > Beeline is not using password value from the URL. > Using LDAP Auth in this case, so the failure is on connect. > bin/beeline -u > "jdbc:hive2://localhost:10000/default;user=test1;password=test1" > On the server side in LdapAuthenticator, the principals come out to (via a > special debug logging) > 2020-02-11T11:10:31,613 INFO [HiveServer2-Handler-Pool: Thread-67] > auth.LdapAuthenticationProviderImpl: Connecting to ldap as > user/password:test1:anonymous > This bug may have been introduced via > https://github.com/apache/hive/commit/749e831060381a8ae4775630efb72d5cd040652f > pass = "" ( an empty string on this line) > https://github.com/apache/hive/blob/master/beeline/src/java/org/apache/hive/beeline/BeeLine.java#L848 > but on this line of code, it checks to see it is null which will not be true > and hence it never picks up from the jdbc url > https://github.com/apache/hive/blob/master/beeline/src/java/org/apache/hive/beeline/BeeLine.java#L900 > It has another chance here but pass != null will always be true and never > goes into the else condition. > https://github.com/apache/hive/blob/master/beeline/src/java/org/apache/hive/beeline/BeeLine.java#L909 -- This message was sent by Atlassian Jira (v8.3.4#803005)