[
https://issues.apache.org/jira/browse/HIVE-22747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036007#comment-17036007
]
Hive QA commented on HIVE-22747:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12993180/HIVE-22747.03.patch
{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17992 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[results_cache_invalidation2]
(batchId=175)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20589/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20589/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20589/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12993180 - PreCommit-HIVE-Build
> Break up DDLSemanticAnalyzer - extract Table info and lock analyzers
> --------------------------------------------------------------------
>
> Key: HIVE-22747
> URL: https://issues.apache.org/jira/browse/HIVE-22747
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available, refactor-ddl
> Attachments: HIVE-22747.01.patch, HIVE-22747.02.patch,
> HIVE-22747.03.patch
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is
> to refactor it in order to have everything cut into more handleable classes
> under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each analyzers
> * have a package for each operation, containing an analyzer, a description,
> and an operation, so the amount of classes under a package is more manageable
> Step #13: extract the table info and lock related analyzers from
> DDLSemanticAnalyzer, and move them under the new package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
