[ https://issues.apache.org/jira/browse/HIVE-22589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035965#comment-17035965 ]
Hive QA commented on HIVE-22589: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 44s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 39s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 23s{color} | {color:blue} storage-api in master has 58 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 48s{color} | {color:blue} standalone-metastore/metastore-common in master has 35 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 34s{color} | {color:blue} common in master has 63 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 43s{color} | {color:blue} serde in master has 197 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 58s{color} | {color:blue} ql in master has 1532 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 46s{color} | {color:blue} llap-server in master has 90 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 9m 42s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 26s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m 32s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s{color} | {color:red} standalone-metastore/metastore-common: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s{color} | {color:red} common: The patch generated 4 new + 370 unchanged - 0 fixed = 374 total (was 370) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 16s{color} | {color:red} serde: The patch generated 2 new + 105 unchanged - 3 fixed = 107 total (was 108) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 56s{color} | {color:red} ql: The patch generated 27 new + 1565 unchanged - 11 fixed = 1592 total (was 1576) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 14s{color} | {color:red} llap-server: The patch generated 3 new + 185 unchanged - 1 fixed = 188 total (was 186) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 23s{color} | {color:red} root: The patch generated 37 new + 2232 unchanged - 15 fixed = 2269 total (was 2247) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 0s{color} | {color:red} ql generated 3 new + 1531 unchanged - 1 fixed = 1534 total (was 1532) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 19m 23s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}101m 2s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | org.apache.hadoop.hive.ql.io.avro.AvroGenericRecordReader.extractWriterProlepticFromMetadata(JobConf, FileSplit, GenericDatumReader) has Boolean return type and returns explicit null At AvroGenericRecordReader.java:return type and returns explicit null At AvroGenericRecordReader.java:[line 179] | | | Nullcheck of result at line 61 of value previously dereferenced in org.apache.hadoop.hive.ql.io.orc.OrcFileFormatProxy.applySargToMetadata(SearchArgument, ByteBuffer, Configuration) At OrcFileFormatProxy.java:61 of value previously dereferenced in org.apache.hadoop.hive.ql.io.orc.OrcFileFormatProxy.applySargToMetadata(SearchArgument, ByteBuffer, Configuration) At OrcFileFormatProxy.java:[line 61] | | | org.apache.hadoop.hive.ql.io.parquet.read.DataWritableReadSupport.getWriterDateProleptic(Map) has Boolean return type and returns explicit null At DataWritableReadSupport.java:and returns explicit null At DataWritableReadSupport.java:[line 293] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile xml | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-20588/dev-support/hive-personality.sh | | git revision | master / fcfc71b | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-20588/yetus/diff-checkstyle-standalone-metastore_metastore-common.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-20588/yetus/diff-checkstyle-common.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-20588/yetus/diff-checkstyle-serde.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-20588/yetus/diff-checkstyle-ql.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-20588/yetus/diff-checkstyle-llap-server.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-20588/yetus/diff-checkstyle-root.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-20588/yetus/new-findbugs-ql.html | | modules | C: storage-api standalone-metastore/metastore-common common serde metastore ql llap-server . itests U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-20588/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Add storage support for ProlepticCalendar in ORC, Parquet, and Avro > ------------------------------------------------------------------- > > Key: HIVE-22589 > URL: https://issues.apache.org/jira/browse/HIVE-22589 > Project: Hive > Issue Type: Bug > Components: Avro, ORC, Parquet > Reporter: Jesus Camacho Rodriguez > Assignee: Jesus Camacho Rodriguez > Priority: Major > Fix For: 4.0.0, 3.2.0, 3.1.3 > > Attachments: HIVE-22589.01.patch, HIVE-22589.02.patch, > HIVE-22589.03.patch, HIVE-22589.04.patch, HIVE-22589.05.patch, > HIVE-22589.06.patch, HIVE-22589.07.patch, HIVE-22589.07.patch, > HIVE-22589.07.patch, HIVE-22589.07.patch, HIVE-22589.patch, HIVE-22589.patch > > > Hive recently moved its processing to the proleptic calendar, which has > created some issues for users who have dates before 1580 AD. > HIVE-22405 extended the column vectors for times & dates to encode which > calendar they are using. > This issue is to support proleptic calendar in ORC, Parquet, and Avro, when > files are written/read by Hive. To preserve compatibility with other engines > until they upgrade their readers, files will be written using hybrid calendar > by default. Default behavior when files do not contain calendar information > in their metadata is configurable. -- This message was sent by Atlassian Jira (v8.3.4#803005)