[ https://issues.apache.org/jira/browse/HIVE-22860?focusedWorklogId=386087&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386087 ]
ASF GitHub Bot logged work on HIVE-22860: ----------------------------------------- Author: ASF GitHub Bot Created on: 12/Feb/20 17:26 Start Date: 12/Feb/20 17:26 Worklog Time Spent: 10m Work Description: aasha commented on pull request #900: HIVE-22860 Support metadata only replication for external tables URL: https://github.com/apache/hive/pull/900#discussion_r378400562 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java ########## @@ -172,7 +172,8 @@ private boolean shouldExamineTablesToDump() { */ private boolean shouldDumpExternalTableLocation() { return conf.getBoolVar(HiveConf.ConfVars.REPL_INCLUDE_EXTERNAL_TABLES) - && !conf.getBoolVar(HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY); + && (!conf.getBoolVar(HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY) && Review comment: Then they will set REPL_INCLUDE_EXTERNAL_TABLES to true, REPL_DUMP_METADATA_ONLY and REPL_DUMP_METADATA_ONLY_FOR_EXTERNAL_TABLE to false. If they set REPL_DUMP_METADATA_ONLY_FOR_EXTERNAL_TABLE to true and REPL_DUMP_METADATA_ONLY to false, then managed table data + metadata will be dumped, but external table metadata only. If they set REPL_DUMP_METADATA_ONLY_FOR_EXTERNAL_TABLE to false but REPL_DUMP_METADATA_ONLY to true then only metadata will be dumped for both external and managed tables ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 386087) Time Spent: 50m (was: 40m) > Support metadata only replication for external tables > ----------------------------------------------------- > > Key: HIVE-22860 > URL: https://issues.apache.org/jira/browse/HIVE-22860 > Project: Hive > Issue Type: Task > Reporter: Aasha Medhi > Assignee: Aasha Medhi > Priority: Major > Labels: pull-request-available > Attachments: HIVE-22860.patch > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)