[
https://issues.apache.org/jira/browse/HIVE-22746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023634#comment-17023634
]
Hive QA commented on HIVE-22746:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991832/HIVE-22746.02.patch
{color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17946 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20343/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20343/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20343/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12991832 - PreCommit-HIVE-Build
> Make TypeCheckProcFactory generic
> ---------------------------------
>
> Key: HIVE-22746
> URL: https://issues.apache.org/jira/browse/HIVE-22746
> Project: Hive
> Issue Type: Improvement
> Components: CBO
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22746.01.patch, HIVE-22746.01.patch,
> HIVE-22746.02.patch, HIVE-22746.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {{TypeCheckProcFactory}} is responsible for processing AST nodes and
> generating ExprNode objects from them. When we generate the expressions for
> Calcite planning, we go through a {{AST node -> ExprNode -> RexNode}}
> transformation. We would like to avoid the overhead of going through the
> ExprNode, and thus generate directly the RexNode from the AST.
> To do that, the first step is to make {{TypeCheckProcFactory}} generic, so it
> can receive an expression factory and create expressions in different realms.
> For the time being, the only factory implementation is the ExprNode factory.
> Thus, this patch focuses mainly on refactoring {{TypeCheckProcFactory}}
> without breaking anything that is already working.
> In a follow-up patch, we will create a {{RexNode}} factory and use it when we
> parse the query in CalcitePlanner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
