[ https://issues.apache.org/jira/browse/HIVE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023537#comment-17023537 ]
Hive QA commented on HIVE-22771: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12991789/HIVE-22771.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17946 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/20340/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20340/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20340/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12991789 - PreCommit-HIVE-Build > Partition location incorrectly formed in FileOutputCommitterContainer > --------------------------------------------------------------------- > > Key: HIVE-22771 > URL: https://issues.apache.org/jira/browse/HIVE-22771 > Project: Hive > Issue Type: Bug > Components: HCatalog > Affects Versions: 1.2.1 > Reporter: Shivam > Assignee: Shivam > Priority: Critical > Labels: pull-request-available > Attachments: HIVE-22771.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Class _HCatOutputFormat_ in package _org.apache.hive.hcatalog.mapreduce_ uses > function _setOutput_ to generate _idHash_ using below statement: > +In file org/apache/hive/hcatalog/mapreduce/HCatOutputFormat.java+ > *line 116: idHash = String.valueOf(Math.random());* > The output of idHash can be similar to values like this : 7.145347157239135E-4 > > And, > in class _FileOutputCommitterContainer_ in package > _org.apache.hive.hcatalog.mapreduce;_ > Uses below statement to compute final partition path: > +*In org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java*+ > *line 366: String finalLocn = jobLocation.replaceAll(Path.SEPARATOR + > SCRATCH_DIR_NAME + "{color:#FF0000}\\d\\.?\\d+"{color},"");* > *line 367: partPath = new Path(finalLocn);* > > Regex used here is incorrect, since it will only remove integers after the > *SCRATCH_DIR_NAME,* and hence will append 'E-4' (for the above example) in > the final partition location. -- This message was sent by Atlassian Jira (v8.3.4#803005)