[
https://issues.apache.org/jira/browse/HIVE-22126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020982#comment-17020982
]
Eugene Chung edited comment on HIVE-22126 at 1/22/20 2:26 PM:
--------------------------------------------------------------
[^HIVE-22126.01.patch] is incorrect and this issue should be reopened.
Google guava has two packages starting with com.google.common and
com.google.thirdparty.publicsuffix.
[https://github.com/google/guava/tree/master/guava/src/com/google]
Plus, some calcite API usages with guava must be adjusted.
(RelOptRule#operand())
https://github.com/EugeneChung/hive/commit/19a4e2dd3655702606876a95878150d495955090
was (Author: euigeun_chung):
[^HIVE-22126.01.patch] is incorrect and this issue should be reopened.
Google guava has two packages starting with com.google.common and
com.google.thirdparty.publicsuffix.
[https://github.com/google/guava/tree/master/guava/src/com/google]
> hive-exec packaging should shade guava
> --------------------------------------
>
> Key: HIVE-22126
> URL: https://issues.apache.org/jira/browse/HIVE-22126
> Project: Hive
> Issue Type: Bug
> Reporter: Vihang Karajgaonkar
> Assignee: Laszlo Pinter
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22126.01.patch
>
>
> The ql/pom.xml includes complete guava library into hive-exec.jar
> https://github.com/apache/hive/blob/master/ql/pom.xml#L990 This causes a
> problems for downstream clients of hive which have hive-exec.jar in their
> classpath since they are pinned to the same guava version as that of hive.
> We should shade guava classes so that other components which depend on
> hive-exec can independently use a different version of guava as needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
