[ https://issues.apache.org/jira/browse/HIVE-22663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017520#comment-17017520 ]
Hive QA commented on HIVE-22663: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 39s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 30s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 3s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 20s{color} | {color:blue} standalone-metastore/metastore-server in master has 181 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 19s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 25s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 32s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 23s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 98 new + 486 unchanged - 79 fixed = 584 total (was 565) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 21s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 32m 6s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-20212/dev-support/hive-personality.sh | | git revision | master / bd8fa5c | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-20212/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | modules | C: standalone-metastore/metastore-server ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-20212/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Quote all table and column names or do not quote any > ---------------------------------------------------- > > Key: HIVE-22663 > URL: https://issues.apache.org/jira/browse/HIVE-22663 > Project: Hive > Issue Type: Bug > Components: HiveServer2, Standalone Metastore > Affects Versions: 4.0.0 > Reporter: Ashutosh Bapat > Assignee: Zoltan Chovan > Priority: Major > Labels: pull-request-available > Attachments: HIVE-22663.2.patch, HIVE-22663.3.patch, > HIVE-22663.4.patch, HIVE-22663.5.patch, HIVE-22663.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > The change in HIVE-22546 is causing following stack trace when I run Hive > with PostgreSQL as backend db for the metastore. > 0: jdbc:hive2://localhost:10000> create database dumpdb with > ('repl.source.for'='1,2,3');0: jdbc:hive2://localhost:10000> create database > dumpdb with ('repl.source.for'='1,2,3');Error: Error while compiling > statement: FAILED: ParseException line 1:28 missing KW_DBPROPERTIES at '(' > near '<EOF>' (state=42000,code=40000)0: jdbc:hive2://localhost:10000> create > database dumpdb with dbproperties ('repl.source.for'='1,2,3');ERROR : FAILED: > Hive Internal Error: org.apache.hadoop.hive.ql.lockmgr.LockException(Error > communicating with the > metastore)org.apache.hadoop.hive.ql.lockmgr.LockException: Error > communicating with the metastore at > org.apache.hadoop.hive.ql.lockmgr.DbTxnManager.commitTxn(DbTxnManager.java:541) > at > org.apache.hadoop.hive.ql.Driver.releaseLocksAndCommitOrRollback(Driver.java:687) > at > org.apache.hadoop.hive.ql.Driver.releaseLocksAndCommitOrRollback(Driver.java:653) > at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:969) > ... stack trace clipped > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748)Caused by: > MetaException(message:Unable to update transaction database > org.postgresql.util.PSQLException: ERROR: relation > "materialization_rebuild_locks" does not exist Position: 13 at > org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2440) > at > org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2183) > at > org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:308) > at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:441) at > org.postgresql.jdbc.PgStatement.execute(PgStatement.java:365) at > This happens because the table names in all the queries in TxnHandler.java > (including the one at 1312, which causes this stack trace) are not quoting > the table names. All the tablenames and column names should be quoted there. > Just the change in HIVE-22546 won't suffice. -- This message was sent by Atlassian Jira (v8.3.4#803005)