[
https://issues.apache.org/jira/browse/HIVE-22355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17011371#comment-17011371
]
Naveen Gangam commented on HIVE-22355:
--------------------------------------
[~matijhs] Looks like the pre-commits did not run with the latest patch. Could
you please re-submit the patch after reviewing the following comments (just
nits)?
Could you please merge these 2 logs messages on consecutive lines of code into
single log message? We don't want too much noise on the beeline shell
beeLine.info("Authentication type:" + auth);
beeLine.info("Connecting to " + url);
Also perhaps we could make this log message a debug message? Currently this
should only be printed when auth=NONE but wondering if this is useful at info
level?
beeLine.info("username:" + username);
Otherwise, the patch looks good to me. +1 pending test results. Thank you
> Beeline should not prompt for hive user and password when authentication is
> NONE
> --------------------------------------------------------------------------------
>
> Key: HIVE-22355
> URL: https://issues.apache.org/jira/browse/HIVE-22355
> Project: Hive
> Issue Type: Bug
> Components: Beeline
> Reporter: Mate Juhasz
> Assignee: Mate Juhasz
> Priority: Major
> Attachments: HIVE-22355.1.patch, HIVE-22355.2.patch,
> HIVE-22355.3.patch, HIVE-22355.4.patch
>
>
> Beeline - without adding the jdbc url - prompts for username and password in
> case hive.server2.authentication=NONE, which is possibly pointless and can be
> misleading for users as any input is accepted.
> In addition, Sqoop has dropped hive cli recently in favor of beeline and if
> there is no authentication set in Hive, Sqoop fails to connect as the process
> stops waiting for the user/password input.
> I think it would be nice to check the auth type "NONE" before reading unused
> inputs from the console before this point:
> https://github.com/apache/hive/blob/master/beeline/src/java/org/apache/hive/beeline/Commands.java#L1641
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
