[
https://issues.apache.org/jira/browse/HIVE-22536?focusedWorklogId=359402&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359402
]
ASF GitHub Bot logged work on HIVE-22536:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Dec/19 13:50
Start Date: 13/Dec/19 13:50
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #866:
HIVE-22536 Improve return path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r357652794
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -464,7 +464,7 @@ Operator genOPTree(ASTNode ast, PlannerContext plannerCtx)
throws SemanticExcept
// 0. Gen Optimized Plan
RelNode newPlan = logicalPlan();
- if (this.conf.getBoolVar(HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP))
{
+ if (ReturnPathManager.shouldUse()) {
if (cboCtx.type == PreCboCtx.Type.VIEW && !materializedView) {
Review comment:
I don't understand this, the line here is to decide if we'd use the "return
path way" or the "non return path way". What are your referring to here as
failing?
My concept was that in case of "supported" we decide between these two by
applying some logic that decides whether the actual command is in the supported
set of commands that are already handled properly with return path, or not. If
it is in it, then it works the same way as "true", if it is not, then it works
the same way as "false".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 359402)
Time Spent: 1h 10m (was: 1h)
> Improve return path enabling/disabling
> --------------------------------------
>
> Key: HIVE-22536
> URL: https://issues.apache.org/jira/browse/HIVE-22536
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch,
> HIVE-22536.03.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Instead of having a boolean for hive.cbo.returnpath.hiveop it should be
> on/off/supported. In case of "supported" it should be used for a subset of
> commands which are already verified to be able to work with return path. This
> is a temporary solution for the time while we are developing return path,
> before making it the only way to handle commands.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
