[
https://issues.apache.org/jira/browse/HIVE-22570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994729#comment-16994729
]
David Mollitor commented on HIVE-22570:
---------------------------------------
[~pvary]
Thanks for the review.
According to the folks at Google, and I am inclined to agree, it is best that a
NPE be generated. This is a warning for developers to not pass in 'null' value
and instead they should be passing in real values (maybe just an empty list).
It's better to throw NPE than to mask the issue and to do a 'null' check at the
beginning of each method and handling it in an ambiguous way (for example,
method returns an empty list, or returns null, if parameter is null).
I personally would remove {{Utilities.mergeUniqElems}} altogether in favor of
{{return new ArrayList<>(new Hashset<>(elems)))}} but we can address these
concerns in a separate jira.
Do you have any issues with this particular patch?
Thanks.
> Review of ExprNodeDesc.java
> ---------------------------
>
> Key: HIVE-22570
> URL: https://issues.apache.org/jira/browse/HIVE-22570
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HIVE-22570.1.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
