[ 
https://issues.apache.org/jira/browse/HIVE-22529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989670#comment-16989670
 ] 

Ashutosh Bapat commented on HIVE-22529:
---------------------------------------

Sorry for the delay. The patch looks good to me. I see that it's already 
committed. Thanks for working on it, [~belugabehr] and [~vgarg].

> Make Debugging Stacktrace More Explicit
> ---------------------------------------
>
>                 Key: HIVE-22529
>                 URL: https://issues.apache.org/jira/browse/HIVE-22529
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>         Attachments: HIVE-22529.1.patch, HIVE-22529.1.patch
>
>
> In some places, the following DEBUG logging was introduced:
> {code:java}
> LOG.debug("Message", new Exception());
> {code}
> The purpose of this is to log the stack trace of the Thread calling this 
> debug logging method.  However, the resulting log message includes the 
> following:
> {code:none}
> 2019-11-19T08:13:31,392 DEBUG [Thread] Logger: Message
> java.lang.Exception: null
>  at ....
> {code}
> To the observer, it appears that there was perhaps some sort of NPE.  Add a 
> message to the Exception being generated to make it more clear that this 
> "Exception" is for debugging purposes and not an actual error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to