[
https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349340&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349340
]
ASF GitHub Bot logged work on HIVE-22463:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Nov/19 20:48
Start Date: 25/Nov/19 20:48
Worklog Time Spent: 10m
Work Description: t3rmin4t0r commented on pull request #853: HIVE-22463
decimal64 multiplication
URL: https://github.com/apache/hive/pull/853#discussion_r350410304
##########
File path:
ql/src/test/results/clientpositive/vector_decimal64_mul_decimal64scalar.q.out
##########
@@ -0,0 +1,142 @@
+PREHOOK: query: create external table
vector_decimal64_mul_decimal64scalar(ss_ext_list_price decimal(7,2),
ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2),
ss_ext_sales_price decimal(7,2)) ROW FORMAT DELIMITED FIELDS TERMINATED BY ','
LINES TERMINATED BY '\n' STORED AS TEXTFILE
+PREHOOK: type: CREATETABLE
+PREHOOK: Output: database:default
+PREHOOK: Output: default@vector_decimal64_mul_decimal64scalar
+POSTHOOK: query: create external table
vector_decimal64_mul_decimal64scalar(ss_ext_list_price decimal(7,2),
ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2),
ss_ext_sales_price decimal(7,2)) ROW FORMAT DELIMITED FIELDS TERMINATED BY ','
LINES TERMINATED BY '\n' STORED AS TEXTFILE
+POSTHOOK: type: CREATETABLE
+POSTHOOK: Output: database:default
+POSTHOOK: Output: default@vector_decimal64_mul_decimal64scalar
+PREHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/decimal64table.csv'
OVERWRITE INTO TABLE vector_decimal64_mul_decimal64scalar
+PREHOOK: type: LOAD
+#### A masked pattern was here ####
+PREHOOK: Output: default@vector_decimal64_mul_decimal64scalar
+POSTHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/decimal64table.csv'
OVERWRITE INTO TABLE vector_decimal64_mul_decimal64scalar
+POSTHOOK: type: LOAD
+#### A masked pattern was here ####
+POSTHOOK: Output: default@vector_decimal64_mul_decimal64scalar
+PREHOOK: query: create table
vector_decimal64_mul_decimal64scalar_tmp(ss_ext_list_price decimal(7,2),
ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2),
ss_ext_sales_price decimal(7,2)) stored as ORC
+PREHOOK: type: CREATETABLE
+PREHOOK: Output: database:default
+PREHOOK: Output: default@vector_decimal64_mul_decimal64scalar_tmp
+POSTHOOK: query: create table
vector_decimal64_mul_decimal64scalar_tmp(ss_ext_list_price decimal(7,2),
ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2),
ss_ext_sales_price decimal(7,2)) stored as ORC
+POSTHOOK: type: CREATETABLE
+POSTHOOK: Output: database:default
+POSTHOOK: Output: default@vector_decimal64_mul_decimal64scalar_tmp
+PREHOOK: query: insert into table vector_decimal64_mul_decimal64scalar_tmp
select * from vector_decimal64_mul_decimal64scalar
+PREHOOK: type: QUERY
+PREHOOK: Input: default@vector_decimal64_mul_decimal64scalar
+PREHOOK: Output: default@vector_decimal64_mul_decimal64scalar_tmp
+POSTHOOK: query: insert into table vector_decimal64_mul_decimal64scalar_tmp
select * from vector_decimal64_mul_decimal64scalar
+POSTHOOK: type: QUERY
+POSTHOOK: Input: default@vector_decimal64_mul_decimal64scalar
+POSTHOOK: Output: default@vector_decimal64_mul_decimal64scalar_tmp
+POSTHOOK: Lineage:
vector_decimal64_mul_decimal64scalar_tmp.ss_ext_discount_amt SIMPLE
[(vector_decimal64_mul_decimal64scalar)vector_decimal64_mul_decimal64scalar.FieldSchema(name:ss_ext_discount_amt,
type:decimal(7,2), comment:null), ]
+POSTHOOK: Lineage: vector_decimal64_mul_decimal64scalar_tmp.ss_ext_list_price
SIMPLE
[(vector_decimal64_mul_decimal64scalar)vector_decimal64_mul_decimal64scalar.FieldSchema(name:ss_ext_list_price,
type:decimal(7,2), comment:null), ]
+POSTHOOK: Lineage: vector_decimal64_mul_decimal64scalar_tmp.ss_ext_sales_price
SIMPLE
[(vector_decimal64_mul_decimal64scalar)vector_decimal64_mul_decimal64scalar.FieldSchema(name:ss_ext_sales_price,
type:decimal(7,2), comment:null), ]
+POSTHOOK: Lineage:
vector_decimal64_mul_decimal64scalar_tmp.ss_ext_wholesale_cost SIMPLE
[(vector_decimal64_mul_decimal64scalar)vector_decimal64_mul_decimal64scalar.FieldSchema(name:ss_ext_wholesale_cost,
type:decimal(7,2), comment:null), ]
+PREHOOK: query: explain vectorization detail select
sum(((ss_ext_list_price-ss_ext_wholesale_cost-ss_ext_discount_amt)+ss_ext_sales_price)*2.2)
from vector_decimal64_mul_decimal64scalar_tmp
+PREHOOK: type: QUERY
+PREHOOK: Input: default@vector_decimal64_mul_decimal64scalar_tmp
+#### A masked pattern was here ####
+POSTHOOK: query: explain vectorization detail select
sum(((ss_ext_list_price-ss_ext_wholesale_cost-ss_ext_discount_amt)+ss_ext_sales_price)*2.2)
from vector_decimal64_mul_decimal64scalar_tmp
+POSTHOOK: type: QUERY
+POSTHOOK: Input: default@vector_decimal64_mul_decimal64scalar_tmp
+#### A masked pattern was here ####
+PLAN VECTORIZATION:
+ enabled: true
+ enabledConditionsMet: [hive.vectorized.execution.enabled IS true]
+
+STAGE DEPENDENCIES:
+ Stage-1 is a root stage
+ Stage-0 depends on stages: Stage-1
+
+STAGE PLANS:
+ Stage: Stage-1
+ Map Reduce
+ Map Operator Tree:
+ TableScan
+ alias: vector_decimal64_mul_decimal64scalar_tmp
+ Statistics: Num rows: 1000 Data size: 448000 Basic stats: COMPLETE
Column stats: COMPLETE
+ TableScan Vectorization:
+ native: true
+ vectorizationSchemaColumns:
[0:ss_ext_list_price:decimal(7,2)/DECIMAL_64,
1:ss_ext_wholesale_cost:decimal(7,2)/DECIMAL_64,
2:ss_ext_discount_amt:decimal(7,2)/DECIMAL_64,
3:ss_ext_sales_price:decimal(7,2)/DECIMAL_64,
4:ROW__ID:struct<writeid:bigint,bucketid:int,rowid:bigint>]
+ Select Operator
+ expressions: ((((ss_ext_list_price - ss_ext_wholesale_cost) -
ss_ext_discount_amt) + ss_ext_sales_price) * 2.2) (type: decimal(13,3))
+ outputColumnNames: _col0
+ Select Vectorization:
+ className: VectorSelectOperator
+ native: true
+ projectedOutputColumnNums: [8]
+ selectExpressions: Decimal64ColMultiplyDecimal64Scalar(col
7:decimal(10,2)/DECIMAL_64, decimal64Val 22, decimalVal 0.22)(children:
Decimal64ColAddDecimal64Column(col 6:decimal(9,2)/DECIMAL_64, col
3:decimal(7,2)/DECIMAL_64)(children: Decimal64ColSubtractDecimal64Column(col
5:decimal(8,2)/DECIMAL_64, col 2:decimal(7,2)/DECIMAL_64)(children:
Decimal64ColSubtractDecimal64Column(col 0:decimal(7,2)/DECIMAL_64, col
1:decimal(7,2)/DECIMAL_64) -> 5:decimal(8,2)/DECIMAL_64) ->
6:decimal(9,2)/DECIMAL_64) -> 7:decimal(10,2)/DECIMAL_64) ->
8:decimal(13,3)/DECIMAL_64
Review comment:
The 0.22 mutliplier for decimalVal is wrong (to print, but the result is
right)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 349340)
Time Spent: 1h 10m (was: 1h)
> Support Decimal64 column multiplication with decimal64 Column/Scalar
> --------------------------------------------------------------------
>
> Key: HIVE-22463
> URL: https://issues.apache.org/jira/browse/HIVE-22463
> Project: Hive
> Issue Type: Bug
> Reporter: Ramesh Kumar Thangarajan
> Assignee: Ramesh Kumar Thangarajan
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch,
> HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch,
> HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Support Decimal64 column multiplication with decimal64 Column/Scalar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
