[ https://issues.apache.org/jira/browse/HIVE-22523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981503#comment-16981503 ]
Hive QA commented on HIVE-22523: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12986633/HIVE-22523.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17717 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19594/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19594/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19594/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12986633 - PreCommit-HIVE-Build > The error handler in LlapRecordReader might block if its queue is full > ---------------------------------------------------------------------- > > Key: HIVE-22523 > URL: https://issues.apache.org/jira/browse/HIVE-22523 > Project: Hive > Issue Type: Bug > Reporter: Attila Magyar > Assignee: Attila Magyar > Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22523.1.patch, HIVE-22523.2.patch > > > InĀ setError() we set the value of an atomic reference (pendingError) and we > also put the error in a queue. The latter seems not just unnecessary but it > might block the caller of the handler if the queue is full. Also closing of > the reader is might not properly handled as some of the flags are not > volatile. -- This message was sent by Atlassian Jira (v8.3.4#803005)