[ https://issues.apache.org/jira/browse/HIVE-21146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974202#comment-16974202 ]
Hive QA commented on HIVE-21146: -------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 46s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 21s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 27s{color} | {color:blue} streaming in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 13m 37s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19420/dev-support/hive-personality.sh | | git revision | master / 065f305 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | modules | C: streaming U: streaming | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-19420/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Enforce TransactionBatch size=1 for blob stores > ----------------------------------------------- > > Key: HIVE-21146 > URL: https://issues.apache.org/jira/browse/HIVE-21146 > Project: Hive > Issue Type: Bug > Components: Streaming, Transactions > Affects Versions: 3.0.0 > Reporter: Eugene Koifman > Assignee: David Lavati > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21146.2.patch, HIVE-21146.2.patch, HIVE-21146.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Streaming Ingest API supports a concept of {{TransactionBatch}} where N > transactions can be opened at once and the data in all of them will be > written to the same delta_x_y directory where each transaction in the batch > can be committed/aborted independently. The implementation relies on > {{FSDataOutputStream.hflush()}} (called from OrcRecordUpdater}} which is > available on HDFS but is often implemented as no-op in Blob store backed > {{FileSystem}} objects. > Need to add a check to {{HiveStreamingConnection()}} constructor to raise an > error if {{builder.transactionBatchSize > 1}} and the target table/partitions > are backed by something that doesn't support {{hflush()}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)