[ https://issues.apache.org/jira/browse/HIVE-21198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968824#comment-16968824 ]
Hive QA commented on HIVE-21198: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12985072/HIVE-21198.10.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 59 failed/errored test(s), 17571 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[annotate_stats_table] (batchId=23) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_union_table] (batchId=30) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ctas] (batchId=7) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ctas_colname] (batchId=65) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ctas_uses_database_location] (batchId=38) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[explain_ddl] (batchId=53) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[fileformat_sequencefile] (batchId=52) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[fileformat_text] (batchId=54) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_duplicate_key] (batchId=7) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input15] (batchId=1) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[inputddl1] (batchId=33) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[inputddl2] (batchId=13) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[inputddl3] (batchId=78) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[merge3] (batchId=65) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[nonReservedKeyWords] (batchId=68) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[nonmr_fetch] (batchId=22) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[nullformatCTAS] (batchId=44) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[nullformat] (batchId=48) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_createas1] (batchId=97) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parallel_orderby] (batchId=60) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[serde_opencsv] (batchId=83) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[serde_regex] (batchId=42) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[skewjoin_noskew] (batchId=18) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[skewjoin_onesideskew] (batchId=79) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[smb_mapjoin9] (batchId=45) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[symlink_text_input_format] (batchId=52) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union25] (batchId=77) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_6] (batchId=15) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_tablesample_rows] (batchId=57) org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver[fileformat_base64] (batchId=294) org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver[serde_regex] (batchId=294) org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testCliDriver[serde_regex] (batchId=296) org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_dynamic_partition] (batchId=198) org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_mv] (batchId=198) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[rcfile_createas1] (batchId=157) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[ctas] (batchId=162) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynamic_partition_pruning] (batchId=169) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[partition_ctas] (batchId=173) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[semijoin_reddedup] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[temp_table] (batchId=186) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_dml] (batchId=170) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_join_result_complex] (batchId=164) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_top_level] (batchId=178) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_char_varchar_1] (batchId=187) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_6] (batchId=164) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_streaming] (batchId=176) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_dynamic_partition_pruning] (batchId=169) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[parallel_orderby] (batchId=194) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_dynamic_partition_pruning] (batchId=193) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_vectorized_dynamic_partition_pruning] (batchId=193) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[hybridgrace_hashjoin_2] (batchId=111) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_explain] (batchId=101) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ctas] (batchId=116) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[skewjoin_noskew] (batchId=121) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[temp_table] (batchId=153) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union25] (batchId=144) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union_top_level] (batchId=141) org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testConstraints (batchId=253) org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=262) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19321/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19321/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19321/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 59 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12985072 - PreCommit-HIVE-Build > Introduce a database object reference class > ------------------------------------------- > > Key: HIVE-21198 > URL: https://issues.apache.org/jira/browse/HIVE-21198 > Project: Hive > Issue Type: Sub-task > Reporter: Zoltan Haindrich > Assignee: David Lavati > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21198.1.patch, HIVE-21198.10.patch, > HIVE-21198.2.patch, HIVE-21198.3.patch, HIVE-21198.4.patch, > HIVE-21198.5.patch, HIVE-21198.6.patch, HIVE-21198.7.patch, > HIVE-21198.8.patch, HIVE-21198.9.patch > > Time Spent: 2h 40m > Remaining Estimate: 0h > > There are many places in which "{databasename}.{tablename}" is passed as a > single string; there are some places where the they travel as 2 separate > arguments. > Idea would be to introduce a simple immutable class with 2 fields ; and pass > these informations together. Making this better is required if we would be > wanting to enable dot in tablenames > HIVE-16907, HIVE-21151 -- This message was sent by Atlassian Jira (v8.3.4#803005)