[
https://issues.apache.org/jira/browse/HIVE-22347?focusedWorklogId=339274&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339274
]
ASF GitHub Bot logged work on HIVE-22347:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/19 10:09
Start Date: 06/Nov/19 10:09
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #817:
HIVE-22347 Break up DDLSemanticAnalyzer - extract Other analyzers
URL: https://github.com/apache/hive/pull/817#discussion_r343011859
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/insert/commit/hook/InsertCommitHookOperation.java
##########
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.hadoop.hive.ql.ddl.misc;
+package org.apache.hadoop.hive.ql.ddl.misc.insert.commit.hook;
Review comment:
I think that it is a good structure that each operation have their own
package, it makes things cleaner. Putting everything under misc would break
this structure, and also has a potential problem if in the future there would
be more operations under misc, it may be a huge package with an endless list of
classes.
I'm ok with renaming the sub packages:
cache.metadata -> metadata
insert.commit.hook -> hooks
msck -> msck
remove.flag -> flags (?)
show.conf -> conf
Would that be ok? I don't see which of these operations are related enough
to be put under the same category, so we'll still have 5 packages, but if in
the future we'll have some new configuration, or metadata, or hook related
stuff, they can go to the same package, or under some sub packages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 339274)
Time Spent: 0.5h (was: 20m)
> Break up DDLSemanticAnalyzer - extract Other analyzers
> ------------------------------------------------------
>
> Key: HIVE-22347
> URL: https://issues.apache.org/jira/browse/HIVE-22347
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available, refactor-ddl
> Attachments: HIVE-22347.01.patch, HIVE-22347.02.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is
> to refactor it in order to have everything cut into more handleable classes
> under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each analyzers
> * have a package for each operation, containing an analyzer, a description,
> and an operation, so the amount of classes under a package is more manageable
> Step #8: extract all the rest of the analyzers from DDLSemanticAnalyzer,
> which can not be classified otherwise, and move them under the new package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
