[ https://issues.apache.org/jira/browse/HIVE-22419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962650#comment-16962650 ]
Hive QA commented on HIVE-22419: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12984282/HIVE-22419.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17546 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19201/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19201/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19201/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12984282 - PreCommit-HIVE-Build > Improve Messages Emitted From HiveMetaStoreClient > ------------------------------------------------- > > Key: HIVE-22419 > URL: https://issues.apache.org/jira/browse/HIVE-22419 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore > Affects Versions: 4.0.0, 3.2.0 > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > Attachments: HIVE-22419.1.patch > > > After reviewing some logs and errors emitted during a QTest run, I would like > to propose some improvements to logging in {{HiveMetaStoreClient}}. > * Remove duplicate logging > * Remove superfluous class {{StackTraceLogger}} > * Do not use contractions in public-facing error messages and logs > * Make all logging side-effect free (see {{connCount}}) > * Code simplification -- This message was sent by Atlassian Jira (v8.3.4#803005)