[ https://issues.apache.org/jira/browse/HIVE-22321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959598#comment-16959598 ]
Hive QA commented on HIVE-22321: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12983999/HIVE-22321.3.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 42 failed/errored test(s), 17544 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[smb_mapjoin_13] (batchId=299) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_numbuckets_partitioned_table2_h23] (batchId=16) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_numbuckets_partitioned_table_h23] (batchId=76) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_partition_clusterby_sortby] (batchId=44) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucket7] (batchId=35) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucket_map_join_2] (batchId=64) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucketsortoptimize_insert_5] (batchId=64) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_udaf_percentile_approx_23] (batchId=39) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dynpart_sort_opt_bucketing] (batchId=96) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[enforce_order] (batchId=46) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[exim_04_evolved_parts] (batchId=35) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_bucket_sort_map_operators] (batchId=73) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_join] (batchId=22) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[partition_coltype_literals] (batchId=14) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[show_create_table_alter] (batchId=33) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[smb_mapjoin_13] (batchId=35) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[smb_mapjoin_21] (batchId=46) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sort_merge_join_desc_1] (batchId=10) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sort_merge_join_desc_2] (batchId=24) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sort_merge_join_desc_3] (batchId=51) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sort_merge_join_desc_4] (batchId=81) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sort_merge_join_desc_5] (batchId=20) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sort_merge_join_desc_6] (batchId=99) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sort_merge_join_desc_7] (batchId=30) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sort_merge_join_desc_8] (batchId=9) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udaf_percentile_approx_23] (batchId=38) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucketsortoptimize_insert_6] (batchId=162) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[enforce_order] (batchId=173) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[smb_mapjoin_15] (batchId=183) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[infer_bucket_sort_map_operators] (batchId=195) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[exim_11_nonpart_noncompat_sorting] (batchId=101) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[exim_12_nonnative_export] (batchId=102) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[sortmerge_mapjoin_mismatch_1] (batchId=102) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[bucket7] (batchId=128) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[bucket_map_join_2] (batchId=140) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[bucketsortoptimize_insert_6] (batchId=116) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[enforce_order] (batchId=132) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_join] (batchId=122) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[sample10] (batchId=135) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[smb_mapjoin_13] (batchId=128) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[smb_mapjoin_15] (batchId=148) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[smb_mapjoin_21] (batchId=132) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19153/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19153/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19153/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 42 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12983999 - PreCommit-HIVE-Build > Setting default nulls last does not take effect when order direction is > specified > --------------------------------------------------------------------------------- > > Key: HIVE-22321 > URL: https://issues.apache.org/jira/browse/HIVE-22321 > Project: Hive > Issue Type: Bug > Components: Parser > Reporter: Krisztian Kasa > Assignee: Krisztian Kasa > Priority: Major > Attachments: HIVE-22321.1.patch, HIVE-22321.2.patch, > HIVE-22321.3.patch > > > {code:java} > SET hive.default.nulls.last=true; > SELECT * FROM t_test ORDER BY col1 ASC; > {code} > {code:java} > POSTHOOK: query: SELECT * FROM t_test ORDER BY col1 ASC > POSTHOOK: type: QUERY > POSTHOOK: Input: default@t_test > #### A masked pattern was here #### > NULL > NULL > NULL > NULL > 3 > 5 > 5 > {code} > [https://github.com/apache/hive/blob/cb83da943c8919e2ab3751244de5c2879c8fda1d/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g#L2510] > > cc. [~jcamachorodriguez] -- This message was sent by Atlassian Jira (v8.3.4#803005)