[
https://issues.apache.org/jira/browse/HIVE-21258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957823#comment-16957823
]
David Mollitor commented on HIVE-21258:
---------------------------------------
In regards to the one FindBugs warning:
{quote}
This method contains a switch statement where default case is missing. Usually
you need to provide a default case.
Because the analysis only looks at the generated bytecode, this warning can be
incorrect triggered if the default case is at the end of the switch statement
and the switch statement doesn't contain break statements for other cases.
{quote}
In this case, the _default_ case is at the end of the switch statement and the
switch statement doesn't contain break statements for other cases. Please
disregard this warning.
> Streamline and Add Warning to PrimitiveObjectInspectorFactory.java
> ------------------------------------------------------------------
>
> Key: HIVE-21258
> URL: https://issues.apache.org/jira/browse/HIVE-21258
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 4.0.0, 3.2.0
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HIVE-21258.1.patch, HIVE-21258.2.patch
>
>
> I just got bit by something pretty good, so I would like to propose adding a
> developer-facing warning into the logs to avoid this situation again.
> Also, this code contains a cache and the cache is pre-populated. Can remove
> a bunch of code, and maybe a little bit of memory, if the cache is populated
> on demand. Also, use new Map {{computeIfAbsent}} API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
