[ https://issues.apache.org/jira/browse/HIVE-22363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956595#comment-16956595 ]
Hive QA commented on HIVE-22363: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12983639/HIVE-22363.03.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17545 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19096/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19096/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19096/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12983639 - PreCommit-HIVE-Build > ReduceDeduplication may leave an invalid GroupByOperator behind in some cases > ----------------------------------------------------------------------------- > > Key: HIVE-22363 > URL: https://issues.apache.org/jira/browse/HIVE-22363 > Project: Hive > Issue Type: Bug > Components: Physical Optimizer > Affects Versions: 3.1.2 > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Priority: Major > Labels: pull-request-available > Attachments: HIVE-22363.01.patch, HIVE-22363.02.patch, > HIVE-22363.03.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > since HIVE-11387 reducededup may traverse {{GroupByOperators}} [as > well|https://github.com/apache/hive/blob/c6626edb65c2cd00576647e54db1995628fe64da/ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationUtilities.java#L244] > But the removal logic only removes the first parent; so if there is some > other operator (a FIL in this case) between the sink and the gby - the > removal may not happen > [here|https://github.com/apache/hive/blob/c6626edb65c2cd00576647e54db1995628fe64da/ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationUtilities.java#L458] > {code} > set hive.cbo.enable=false; > drop table if exists xl1; > create table xl1 as > select '1' as mdl_yr_desc, 2 as seq_no,'3' as opt_desc1,4 as opt_desc,1 as > row_num; > explain > select trim(base.mdl_yr_desc) mdl_yr_desc, trim(base.opt_desc) opt_desc > from > ( > SELECT trim(mdl_yr_desc) mdl_yr_desc, concat_ws(' ', > collect_set(trim(opt_desc1))) AS opt_desc > from > ( > select t14304.* > from > ( > select * from xl1 > ) t14304 > where row_num = 1 > order by trim(mdl_yr_desc), cast(seq_no as int) asc > ) x > group by trim(mdl_yr_desc) > ) base > inner join > ( > select 1 as v > ) dedup > on trim(base.mdl_yr_desc) != dedup.v > group by trim(base.mdl_yr_desc), trim(base.opt_desc) ; > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)