[ https://issues.apache.org/jira/browse/HIVE-21954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955645#comment-16955645 ]
Hive QA commented on HIVE-21954: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12983554/HIVE-21954.03.patch {color:green}SUCCESS:{color} +1 due to 11 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 17133 tests executed *Failed tests:* {noformat} TestBeeLineDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=299) TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=299) TestMinimrCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=299) TestTezPerfCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=299) TestTezPerfConstraintsCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=299) org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver (batchId=301) org.apache.hadoop.hive.llap.security.TestLlapSignerImpl.testSigning (batchId=364) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19080/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19080/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19080/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 7 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12983554 - PreCommit-HIVE-Build > QTest: support for running qtests on various metastore DBs > ---------------------------------------------------------- > > Key: HIVE-21954 > URL: https://issues.apache.org/jira/browse/HIVE-21954 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore, Testing Infrastructure > Reporter: László Bodor > Assignee: László Bodor > Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21954.01.patch, HIVE-21954.02.patch, > HIVE-21954.03.patch > > > In HIVE-21940, a postgres metastore related issue has been fixed, and a local > reproduction has been provided. > {code} > export QTEST_LEAVE_FILES=true > docker kill metastore-test-postgres-install > docker rm metastore-test-postgres-install > cd standalone-metastore > mvn verify -DskipITests=false -Dit.test=ITestPostgres#install -Dtest=nosuch > -Dmetastore.itest.no.stop.container=true > cd .. > mvn test -Dtest.output.overwrite=true -Pitests,hadoop-2 -pl itests/qtest > -Dtest=TestCliDriver -Dqfile=partition_params_postgres.q > -Dhive.metastore.rawstore.impl=org.apache.hadoop.hive.metastore.ObjectStore > {code} > The problem with this solution is that data/conf/hive-site.xml has to be > edited manually. My proposal is to introduce a property > (-Dmetastore.db=postgres), which can take care of the parameters on the fly. > 2 supported solutions could be: > 1. simple parameters: -Dmetastore.db=postgres > In this case, tests depend on settings from ITestPostgres class (password, > db, etc.) > 2. verbose but flexible parameters: [see hive-site.xml HIVE-21940's repro > patch|https://issues.apache.org/jira/secure/attachment/12973534/HIVE-21940.repro.patch] > > In the first implementation, I would not start metastore db automatically > (which is done be 'mvn verify ...'), but it's still under planning. > In the long term, we should consider running this kind of tests in precommit > phase, so maybe -Dmetastore.db=postgres could start metastore db > automatically. Also we should consider running some qtests on various > metastores. I would not pick randomly, but choose some "metastore-heavy" ones > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)