[ 
https://issues.apache.org/jira/browse/HIVE-21414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953762#comment-16953762
 ] 

David Mollitor commented on HIVE-21414:
---------------------------------------

{code:java}
if (hasMetastoreBasedSchema(SessionState.getSessionConf(), serializationLib)) {
    return tTable.getSd().getCols();
}
...
public static boolean hasMetastoreBasedSchema(HiveConf conf, String serdeLib) {
  return StringUtils.isEmpty(serdeLib) ||
      
conf.getStringCollection(ConfVars.SERDESUSINGMETASTOREFORSCHEMA.varname).contains(serdeLib);
}
{code}

Get the schema from the database (including comments) if the 
{{serializationLib}} is in the list of {{SERDESUSINGMETASTOREFORSCHEMA}}... 
which is marked deprecated...

{{SERDES_USING_METASTORE_FOR_SCHEMA}} is the new one and is where I added the 
JSON SerDe to.

I think it should stay there and another patch should remove the deprecated 
configuration.

> Hive JSON SerDe Does Not Properly Handle Field Comments
> -------------------------------------------------------
>
>                 Key: HIVE-21414
>                 URL: https://issues.apache.org/jira/browse/HIVE-21414
>             Project: Hive
>          Issue Type: Improvement
>          Components: Serializers/Deserializers
>    Affects Versions: 4.0.0, 3.2.0
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>         Attachments: HIVE-21414.1.patch, HIVE-21414.1.patch
>
>
> Field comments are handed to the JSON SerDe from HMS and then are ignored.  
> The result is that all field comments are 'from deserializer' and cannot be 
> changed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to