[ https://issues.apache.org/jira/browse/HIVE-21884?focusedWorklogId=329442&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329442 ]
ASF GitHub Bot logged work on HIVE-21884: ----------------------------------------- Author: ASF GitHub Bot Created on: 16/Oct/19 21:39 Start Date: 16/Oct/19 21:39 Worklog Time Spent: 10m Work Description: kgyrtkirk commented on pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r335716046 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java ########## @@ -2318,4 +2318,10 @@ public void addPropertyReadEntry(Map<String, String> tblProps, Set<ReadEntity> i } } } + + protected void unparse() { + UnparseTranslator unparseTranslator = new UnparseTranslator(conf); Review comment: this method executes the unparse translations; having it like this enables to unparse any kind of BSA statement not just SA statements. I've renamed the method to `executeUnparseTranlations` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 329442) Time Spent: 5h 20m (was: 5h 10m) > Scheduled query support > ----------------------- > > Key: HIVE-21884 > URL: https://issues.apache.org/jira/browse/HIVE-21884 > Project: Hive > Issue Type: Improvement > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21844.04.patch, HIVE-21844.05.patch, > HIVE-21844.06.patch, HIVE-21844.07.patch, HIVE-21844.08.patch, > HIVE-21844.09.patch, HIVE-21844.15.patch, HIVE-21844.19.patch, > HIVE-21884.01.patch, HIVE-21884.02.patch, HIVE-21884.03.patch, > HIVE-21884.09.patch, HIVE-21884.10.patch, HIVE-21884.10.patch, > HIVE-21884.11.patch, HIVE-21884.12.patch, HIVE-21884.13.patch, > HIVE-21884.14.patch, HIVE-21884.14.patch, HIVE-21884.14.patch, > HIVE-21884.16.patch, HIVE-21884.17.patch, HIVE-21884.18.patch, > HIVE-21884.20.patch, Scheduled queries2.pdf > > Time Spent: 5h 20m > Remaining Estimate: 0h > > design document: > https://docs.google.com/document/d/1mJSFdJi_1cbxJTXC9QvGw2rQ3zzJkNfxOO6b5esmyCE/edit# > in case the google doc is not reachable: [^Scheduled queries2.pdf] -- This message was sent by Atlassian Jira (v8.3.4#803005)