[
https://issues.apache.org/jira/browse/HIVE-22347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952940#comment-16952940
]
Hive QA commented on HIVE-22347:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983130/HIVE-22347.02.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17541 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19018/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19018/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19018/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983130 - PreCommit-HIVE-Build
> Break up DDLSemanticAnalyzer - extract Other analyzers
> ------------------------------------------------------
>
> Key: HIVE-22347
> URL: https://issues.apache.org/jira/browse/HIVE-22347
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available, refactor-ddl
> Attachments: HIVE-22347.01.patch, HIVE-22347.02.patch
>
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is
> to refactor it in order to have everything cut into more handleable classes
> under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each analyzers
> * have a package for each operation, containing an analyzer, a description,
> and an operation, so the amount of classes under a package is more manageable
> Step #8: extract all the rest of the analyzers from DDLSemanticAnalyzer,
> which can not be classified otherwise, and move them under the new package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
