[
https://issues.apache.org/jira/browse/HIVE-22274?focusedWorklogId=328112&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328112
]
ASF GitHub Bot logged work on HIVE-22274:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/19 20:23
Start Date: 14/Oct/19 20:23
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on pull request #809:
HIVE-22274: upgrade Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r334602095
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java
##########
@@ -225,7 +225,7 @@ public JoinPredicateInfo getJoinPredicateInfo() {
private boolean containsOuter() {
for (JoinRelType joinType : joinTypes) {
- if (joinType != JoinRelType.INNER) {
+ if (joinType != JoinRelType.INNER && joinType != JoinRelType.SEMI) {
Review comment:
It would be better to whitelist this for outer types (FULL, LEFT, RIGHT).
@scarlin-cloudera Either we can create separate jira or we can make the
change with this patch..upto you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 328112)
Time Spent: 0.5h (was: 20m)
> Upgrade Calcite version to 1.21.0
> ---------------------------------
>
> Key: HIVE-22274
> URL: https://issues.apache.org/jira/browse/HIVE-22274
> Project: Hive
> Issue Type: Task
> Affects Versions: 3.1.2
> Reporter: Steve Carlin
> Assignee: Steve Carlin
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22274.1.patch, HIVE-22274.2.patch,
> HIVE-22274.3.patch, HIVE-22274.4.patch, HIVE-22274.5.patch,
> HIVE-22274.6.patch, HIVE-22274.7.patch, HIVE-22274.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
