[ https://issues.apache.org/jira/browse/HIVE-22284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951116#comment-16951116 ]
Hive QA commented on HIVE-22284: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12982943/HIVE-22284.6.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17509 tests executed *Failed tests:* {noformat} TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=184) [vector_windowing_expressions.q,tez_union_group_by.q,materialized_view_rewrite_no_join_opt_2.q,vector_like_2.q,llap_acid.q,sqlmerge.q,schema_evol_orc_acid_part_update_llap_io.q,vector_windowing_gby.q,rfc5424_parser.q,lateral_view.q,vector_decimal_join.q,optimize_nullscan.q,vectorization_decimal_date.q,schema_evol_orc_nonvec_table_llap_io.q,udaf_all_keyword.q,acid_vectorization_original.q,tez_fsstat.q,vector_fullouter_mapjoin_1_optimized_passthru.q,vector_mapjoin_reduce.q,join_acid_non_acid.q,empty_join.q,auto_join21.q,materialized_view_partition_cluster.q,tez_input_counters.q,skiphf_aggr2.q,vector_groupby_sort_11.q,schema_evol_orc_nonvec_part_all_complex_llap_io.q,orc_ppd_timestamp.q,vector_decimal_1.q,tez_fixed_bucket_pruning.q] {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18981/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18981/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18981/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12982943 - PreCommit-HIVE-Build > Improve LLAP CacheContentsTracker to collect and display correct statistics > --------------------------------------------------------------------------- > > Key: HIVE-22284 > URL: https://issues.apache.org/jira/browse/HIVE-22284 > Project: Hive > Issue Type: Improvement > Components: llap > Reporter: Ádám Szita > Assignee: Ádám Szita > Priority: Major > Attachments: HIVE-22284.0.patch, HIVE-22284.1.patch, > HIVE-22284.2.patch, HIVE-22284.3.patch, HIVE-22284.4.patch, > HIVE-22284.5.patch, HIVE-22284.6.patch, HIVE-22284.7.patch > > > When keeping track of which buffers correspond to what Hive objects, > CacheContentsTracker relies on cache tags. > Currently a tag is a simple String that ideally holds DB and table name, and > a partition spec concatenated by . and / . The information here is derived > from the Path of the file that is getting cached. Needless to say sometimes > this produces a wrong tag especially for external tables. > Also there's a bug when calculating aggregated stats for a 'parent' tag > (corresponding to the table of the partition) because the overall maxCount > and maxSize do not add up to the sum of those in the partitions. This happens > when buffers get removed from the cache. > -- This message was sent by Atlassian Jira (v8.3.4#803005)