[
https://issues.apache.org/jira/browse/HIVE-22276?focusedWorklogId=327823&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327823
]
ASF GitHub Bot logged work on HIVE-22276:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/19 14:04
Start Date: 14/Oct/19 14:04
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #800:
HIVE-22276 Break up DDLSemanticAnalyzer - extract View related analyzers
URL: https://github.com/apache/hive/pull/800#discussion_r334498535
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rewrite/AlterMaterializedViewRewriteDesc.java
##########
@@ -27,17 +27,17 @@
*/
@Explain(displayName = "Alter Materialized View Rewrite", explainLevels = {
Level.USER, Level.DEFAULT, Level.EXTENDED })
public class AlterMaterializedViewRewriteDesc implements DDLDescWithWriteId {
- private final String fqMaterializedViewName;
+ private final String materializedViewName;
private final boolean rewriteEnable;
- public AlterMaterializedViewRewriteDesc(String fqMaterializedViewName,
boolean rewriteEnable) {
- this.fqMaterializedViewName = fqMaterializedViewName;
+ public AlterMaterializedViewRewriteDesc(String materializedViewName, boolean
rewriteEnable) {
+ this.materializedViewName = materializedViewName;
Review comment:
Put back the fq prefix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 327823)
Time Spent: 50m (was: 40m)
> Break up DDLSemanticAnalyzer - extract View related analyzers
> -------------------------------------------------------------
>
> Key: HIVE-22276
> URL: https://issues.apache.org/jira/browse/HIVE-22276
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available, refactor-ddl
> Attachments: HIVE-22276.01.patch, HIVE-22276.02.patch,
> HIVE-22276.03.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is
> to refactor it in order to have everything cut into more handleable classes
> under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each analyzers
> * have a package for each operation, containing an analyzer, a description,
> and an operation, so the amount of classes under a package is more manageable
> Step #6: extract all the vire related analyzers from DDLSemanticAnalyzer, and
> move them under the new package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
