[
https://issues.apache.org/jira/browse/HIVE-22324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950093#comment-16950093
]
Hive QA commented on HIVE-22324:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
2s{color} | {color:blue} ql in master has 1549 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m
37s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
4s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
44s{color} | {color:red} ql: The patch generated 10 new + 360 unchanged - 11
fixed = 370 total (was 371) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
55s{color} | {color:red} root: The patch generated 10 new + 360 unchanged - 11
fixed = 370 total (was 371) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
5s{color} | {color:red} ql generated 9 new + 1546 unchanged - 3 fixed = 1555
total (was 1549) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m
0s{color} | {color:red} ql generated 4 new + 96 unchanged - 4 fixed = 100 total
(was 100) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 6m
23s{color} | {color:red} root generated 4 new + 333 unchanged - 4 fixed = 337
total (was 337) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 61m 40s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Dead store to joinInfo in
org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, Set, JoinRelType, boolean) At
HiveRelFactories.java:org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, Set, JoinRelType, boolean) At HiveRelFactories.java:[line
171] |
| | Dead store to joinInfo in
org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, JoinRelType, Set, boolean) At
HiveRelFactories.java:org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, JoinRelType, Set, boolean) At HiveRelFactories.java:[line
158] |
| | Dead store to joinInfo in
org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveSemiJoinFactoryImpl.createSemiJoin(RelNode,
RelNode, RexNode) At
HiveRelFactories.java:org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveSemiJoinFactoryImpl.createSemiJoin(RelNode,
RelNode, RexNode) At HiveRelFactories.java:[line 188] |
| | Dead store to rightKeys in
org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveRelDecorrelator.decorrelateRel(LogicalCorrelate)
At
HiveRelDecorrelator.java:org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveRelDecorrelator.decorrelateRel(LogicalCorrelate)
At HiveRelDecorrelator.java:[line 1453] |
| | Dead store to leftKeys in
org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveRelDecorrelator.decorrelateRel(LogicalCorrelate)
At
HiveRelDecorrelator.java:org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveRelDecorrelator.decorrelateRel(LogicalCorrelate)
At HiveRelDecorrelator.java:[line 1452] |
| | instanceof will always return true for all non-null values in new
org.apache.hadoop.hive.ql.optimizer.calcite.stats.HiveRelMdPredicates$JoinConditionBasedPredicateInference(Join,
RexNode, RexNode), since all org.apache.calcite.rel.core.Join are instances of
org.apache.calcite.rel.core.Join At HiveRelMdPredicates.java:for all non-null
values in new
org.apache.hadoop.hive.ql.optimizer.calcite.stats.HiveRelMdPredicates$JoinConditionBasedPredicateInference(Join,
RexNode, RexNode), since all org.apache.calcite.rel.core.Join are instances of
org.apache.calcite.rel.core.Join At HiveRelMdPredicates.java:[line 318] |
| | Redundant nullcheck of lefts, which is known to be non-null in
org.apache.hadoop.hive.ql.optimizer.calcite.stats.HiveRelMdSize.averageColumnSizes(HiveSemiJoin,
RelMetadataQuery) Redundant null check at HiveRelMdSize.java:is known to be
non-null in
org.apache.hadoop.hive.ql.optimizer.calcite.stats.HiveRelMdSize.averageColumnSizes(HiveSemiJoin,
RelMetadataQuery) Redundant null check at HiveRelMdSize.java:[line 90] |
| | Possible null pointer dereference of b in
org.apache.hadoop.hive.ql.optimizer.calcite.translator.ASTBuilder.join(ASTNode,
ASTNode, JoinRelType, ASTNode) on exception path Dereferenced at
ASTBuilder.java:b in
org.apache.hadoop.hive.ql.optimizer.calcite.translator.ASTBuilder.join(ASTNode,
ASTNode, JoinRelType, ASTNode) on exception path Dereferenced at
ASTBuilder.java:[line 179] |
| | Switch statement found in
org.apache.hadoop.hive.ql.optimizer.calcite.translator.ASTBuilder.join(ASTNode,
ASTNode, JoinRelType, ASTNode) where default case is missing At
ASTBuilder.java:ASTNode, JoinRelType, ASTNode) where default case is missing
At ASTBuilder.java:[lines 161-175] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc xml compile findbugs
checkstyle |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18962/dev-support/hive-personality.sh
|
| git revision | master / f16509a |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18962/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18962/yetus/diff-checkstyle-root.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18962/yetus/whitespace-eol.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18962/yetus/new-findbugs-ql.html
|
| javadoc |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18962/yetus/diff-javadoc-javadoc-ql.txt
|
| javadoc |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18962/yetus/diff-javadoc-javadoc-root.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18962/yetus/patch-asflicense-problems.txt
|
| modules | C: ql . U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18962/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Checkin test output changes due to Calcite 1.21 upgrade
> -------------------------------------------------------
>
> Key: HIVE-22324
> URL: https://issues.apache.org/jira/browse/HIVE-22324
> Project: Hive
> Issue Type: Sub-task
> Reporter: Steve Carlin
> Assignee: Steve Carlin
> Priority: Major
> Attachments: HIVE-22324.patch
>
>
> On the upgrade to Calcite 1.21, CALC-2991 caused a change in some of the
> planner output. This initial hive checkin for the upgrade did an override of
> the RelMdMaxRowCount class to simulate 1.19 behavior.
> This task is to remove the HiveRelMdMaxRowCount class, use the new 1.21 code,
> and change the q.out files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
