[ https://issues.apache.org/jira/browse/HIVE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947155#comment-16947155 ]
Hive QA commented on HIVE-21246: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12982512/HIVE-21246.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17516 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18911/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18911/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18911/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12982512 - PreCommit-HIVE-Build > Un-bury DelimitedJSONSerDe from PlanUtils.java > ---------------------------------------------- > > Key: HIVE-21246 > URL: https://issues.apache.org/jira/browse/HIVE-21246 > Project: Hive > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > Attachments: HIVE-21246.1.patch, HIVE-21246.1.patch, > HIVE-21246.2.patch > > > Ultimately, I'd like to get rid of > {{org.apache.hadoop.hive.serde2.DelimitedJSONSerDe}}, but for now, trying to > make it easier to get rid of later. It's currently buried in > {{PlanUtils.java}}. > A SerDe and a boolean flag gets passed into these methods. If the flag is > set to true, the specified SerDe is overwritten and assigned to > {{DelimitedJSONSerDe}}. This is not documented anywhere and it's a weird > thing to do, just pass in the required SerDe from the start instead of > sending the wrong SerDe and a flag to overwrite it. -- This message was sent by Atlassian Jira (v8.3.4#803005)