[ 
https://issues.apache.org/jira/browse/HIVE-11595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709751#comment-14709751
 ] 

Sergey Shelukhin commented on HIVE-11595:
-----------------------------------------

1-2 done, although it is misleading cause the buffer contains the entire footer 
structure, incl. metadata and PS, not just OrcProto.Footer.
3-4 sure
5 there's a comment in the class. It could be changed to expand FileMetaInfo 
but FileMetaInfo is serialized in splits, so it would be confusing because the 
newly added fields would be missing on the other side (they are only used 
during split generation)

> refactor ORC footer reading to make it usable from outside
> ----------------------------------------------------------
>
>                 Key: HIVE-11595
>                 URL: https://issues.apache.org/jira/browse/HIVE-11595
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-10595.patch, HIVE-11595.01.patch
>
>
> If ORC footer is read from cache, we want to parse it without having the 
> reader, opening a file, etc. I thought it would be as simple as protobuf 
> parseFrom bytes, but apparently there's bunch of stuff going on there. It 
> needs to be accessible via something like parseFrom(ByteBuffer), or similar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to