[ https://issues.apache.org/jira/browse/HIVE-22213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932271#comment-16932271 ]
Hive QA commented on HIVE-22213: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 11s{color} | {color:blue} standalone-metastore/metastore-server in master has 178 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 23s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 1 new + 533 unchanged - 0 fixed = 534 total (was 533) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 20s{color} | {color:red} standalone-metastore/metastore-server generated 2 new + 178 unchanged - 0 fixed = 180 total (was 178) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 14m 30s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:standalone-metastore/metastore-server | | | Null passed for non-null parameter of org.apache.hadoop.hive.metastore.txn.TxnStore.cleanupRecords(HiveObjectType, Database, Table, Iterator) in org.apache.hadoop.hive.metastore.AcidEventListener.onDropPartition(DropPartitionEvent) At AcidEventListener.java:of org.apache.hadoop.hive.metastore.txn.TxnStore.cleanupRecords(HiveObjectType, Database, Table, Iterator) in org.apache.hadoop.hive.metastore.AcidEventListener.onDropPartition(DropPartitionEvent) At AcidEventListener.java:[line 73] | | | Null passed for non-null parameter of org.apache.hadoop.hive.metastore.txn.TxnStore.cleanupRecords(HiveObjectType, Database, Table, Iterator) in org.apache.hadoop.hive.metastore.AcidEventListener.onDropTable(DropTableEvent) At AcidEventListener.java:of org.apache.hadoop.hive.metastore.txn.TxnStore.cleanupRecords(HiveObjectType, Database, Table, Iterator) in org.apache.hadoop.hive.metastore.AcidEventListener.onDropTable(DropTableEvent) At AcidEventListener.java:[line 65] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18633/dev-support/hive-personality.sh | | git revision | master / 79e7d2c | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18633/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-18633/yetus/new-findbugs-standalone-metastore_metastore-server.html | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18633/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > TxnHander cleanupRecords should only clean records belonging to default > catalog > ------------------------------------------------------------------------------- > > Key: HIVE-22213 > URL: https://issues.apache.org/jira/browse/HIVE-22213 > Project: Hive > Issue Type: Bug > Components: Transactions > Reporter: Vineet Garg > Assignee: Vineet Garg > Priority: Major > Attachments: HIVE-22213.1.patch > > > Currently it removes record for given database and given table without > checking for the catalog, as a result it can end up removing records when it > shouldn't. -- This message was sent by Atlassian Jira (v8.3.4#803005)