[
https://issues.apache.org/jira/browse/HIVE-22202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931758#comment-16931758
]
Hive QA commented on HIVE-22202:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12980478/HIVE-22202.3.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 16760 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18622/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18622/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18622/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12980478 - PreCommit-HIVE-Build
> Remove unnecessary code from ObjectStore.java
> ---------------------------------------------
>
> Key: HIVE-22202
> URL: https://issues.apache.org/jira/browse/HIVE-22202
> Project: Hive
> Issue Type: Task
> Components: Hive
> Reporter: Hankó Gergely
> Assignee: Hankó Gergely
> Priority: Minor
> Attachments: HIVE-22202.1.patch, HIVE-22202.2.patch,
> HIVE-22202.3.patch
>
>
> Remove unnecessary code
> * remove unnecessary/unused variables
> * remove unused private methods
> * remove unnecessary throws declarations
> * remove unnecessary conditionals that are guaranteed to always give the
> same result
> * simplify collection handling
> ** use member sort() instead of Collections.sort()
> ** use addAll() instead of adding one-by-one in a loop
> * remove Javadoc that doesn't give additional information
> * use try with resource where possible
> * remove unnecessary explicit type arguments
> * remove redundant warning suppression
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
