[
https://issues.apache.org/jira/browse/HIVE-21977?focusedWorklogId=278072&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-278072
]
ASF GitHub Bot logged work on HIVE-21977:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/19 08:56
Start Date: 17/Jul/19 08:56
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #720:
HIVE-21977 Clean up DescTableOperation
URL: https://github.com/apache/hive/pull/720#discussion_r304290846
##########
File path: ql/src/test/results/clientpositive/alterColumnStats.q.out
##########
@@ -144,35 +144,15 @@ PREHOOK: Input: default@p_n0
POSTHOOK: query: desc formatted p_n0 c1
POSTHOOK: type: DESCTABLE
POSTHOOK: Input: default@p_n0
-col_name c1
-data_type string
-min
Review comment:
Hive either shows the data in the vertical format, which is supposed to be
shown in case of having statistics, and the horizontal format with fewer
fields, when we don't have the statistics. The previous somewhat messy code
produced anomalies like this one, that we didn't have the statistics, still it
was shown in vertical format. After the cleanup that small bug is also fixed,
like in this case: we don't have statistics, so it is shown in horizontal
format.
In other files for example alter_table_column_stats.q.out there are
statistics, and thus there is still vertical format present with data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 278072)
Time Spent: 0.5h (was: 20m)
> Clean up DescTableOperation
> ---------------------------
>
> Key: HIVE-21977
> URL: https://issues.apache.org/jira/browse/HIVE-21977
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Affects Versions: 3.1.1
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available, refactor-ddl
> Fix For: 4.0.0
>
> Attachments: HIVE-21977.01.patch, HIVE-21977.02.patch,
> HIVE-21977.03.patch, HIVE-21977.04.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> DescTable operation is messy, with some unclean solutions. It should be
> refactored.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
