[ https://issues.apache.org/jira/browse/HIVE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881310#comment-16881310 ]
Zoltan Haindrich commented on HIVE-21962: ----------------------------------------- +1 pending tests we also have an incremental compilation issue around SA ; mostly because of "? extends Serializable" can be reproduced with: {code} git clean -dfx mvn install -pl ql -am -DskipTests touch `find . -name Sema*A*java` `find . -name Task*Factory.java` mvn install -pl ql -DskipTests {code} > Replacing ArrayList params with List in and around PlanUtils and MapWork > ------------------------------------------------------------------------ > > Key: HIVE-21962 > URL: https://issues.apache.org/jira/browse/HIVE-21962 > Project: Hive > Issue Type: Improvement > Reporter: Ivan Suller > Assignee: Ivan Suller > Priority: Minor > Attachments: HIVE-21962.1.patch, HIVE-21962.1.patch > > > Using the implementing class is usually a bad practice. OO suggest to use the > least restrictive interface instead. ArrayList is used in many-many methods > as a parameter - this is just a tiny part of this work. -- This message was sent by Atlassian JIRA (v7.6.3#76005)