[
https://issues.apache.org/jira/browse/HIVE-18842?focusedWorklogId=271998&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-271998
]
ASF GitHub Bot logged work on HIVE-18842:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/19 05:23
Start Date: 04/Jul/19 05:23
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #696: HIVE-18842
URL: https://github.com/apache/hive/pull/696#discussion_r300232292
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/view/CreateViewDesc.java
##########
@@ -70,21 +72,28 @@
private String storageHandler; // only used for materialized views
private Map<String, String> serdeProps; // only used for materialized views
private Set<String> tablesUsed; // only used for materialized views
+ private List<String> sortColNames; // only used for materialized views
+ private List<FieldSchema> sortCols; // only used for materialized views
Review comment:
You are right, this is not really required. We only use it to print the
column names together with their types in the explain for `CREATE MATERIALIZED
VIEW` statement. Logic is similar to partition columns, this will only be
needed if we store these columns as entries in the SORT / BUCKET columns in
metastore (as we do for normal tables), but currently we do not do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 271998)
Time Spent: 1h 10m (was: 1h)
> CLUSTERED ON/DISTRIBUTED ON+SORTED ON support for materialized views
> --------------------------------------------------------------------
>
> Key: HIVE-18842
> URL: https://issues.apache.org/jira/browse/HIVE-18842
> Project: Hive
> Issue Type: New Feature
> Components: Materialized views
> Affects Versions: 3.0.0
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Major
> Labels: pull-request-available, todoc4.0
> Attachments: HIVE-18842.01.patch, HIVE-18842.01.patch,
> HIVE-18842.02.patch, HIVE-18842.03.patch, HIVE-18842.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We should support defining a {{CLUSTERED ON/DISTRIBUTED ON+SORTED ON}}
> specification for materialized views.
> The syntax should be extended as follows:
> {code:sql}
> CREATE MATERIALIZED VIEW [IF NOT EXISTS] [db_name.]materialized_view_name
> [COMMENT materialized_view_comment]
> [PARTITIONED ON (col_name, ...)]
> [CLUSTERED ON (col_name, ...) | DISTRIBUTED ON (col_name, ...) SORTED ON
> (col_name, ...)] -- NEW!
> [
> [ROW FORMAT row_format]
> [STORED AS file_format]
> | STORED BY 'storage.handler.class.name' [WITH SERDEPROPERTIES (...)]
> ]
> [LOCATION hdfs_path]
> [TBLPROPERTIES (property_name=property_value, ...)]
> AS select_statement;
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
