[
https://issues.apache.org/jira/browse/HIVE-21908?focusedWorklogId=271802&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-271802
]
ASF GitHub Bot logged work on HIVE-21908:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/19 18:09
Start Date: 03/Jul/19 18:09
Worklog Time Spent: 10m
Work Description: odraese commented on pull request #699: HIVE-21908:
LlapDaemon node status should be reflected in the metrics
URL: https://github.com/apache/hive/pull/699#discussion_r300091138
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java
##########
@@ -213,6 +215,10 @@ public synchronized void setCapacity(int newNumExecutors,
int newWaitQueueSize)
numSlotsAvailable.addAndGet(newNumExecutors - maxParallelExecutors);
maxParallelExecutors = newNumExecutors;
waitQueue.setWaitQueueSize(newWaitQueueSize);
+ if (metrics != null) {
Review comment:
I found only one case (test) where metrics could be passed in a null. So, I
would wonder if it would make sense to mock metrics in that test and to always
assume/verify that we have metrics being passed in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 271802)
Time Spent: 20m (was: 10m)
> LlapDaemon node status should be reflected in the metrics
> ---------------------------------------------------------
>
> Key: HIVE-21908
> URL: https://issues.apache.org/jira/browse/HIVE-21908
> Project: Hive
> Issue Type: Sub-task
> Components: llap
> Reporter: Peter Vary
> Assignee: Antal Sinkovits
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21908.01.patch, HIVE-21908.02.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When we enable/disable a node it should be reflected in the LlapDaemon
> metrics, so the administrator can act upon the disabled nodes. They can
> manually check the status and either reenable them by restart, or fix the
> existing issues causing the problems
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
