[
https://issues.apache.org/jira/browse/HIVE-21907?focusedWorklogId=266600&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-266600
]
ASF GitHub Bot logged work on HIVE-21907:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/19 12:33
Start Date: 25/Jun/19 12:33
Worklog Time Spent: 10m
Work Description: pvary commented on pull request #685: HIVE-21907: Add a
new LlapDaemon Management API method to set the daemon capacity
URL: https://github.com/apache/hive/pull/685#discussion_r297162456
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java
##########
@@ -176,6 +181,31 @@ public TaskExecutorService(int numExecutors, int
waitQueueSize,
Futures.addCallback(future, new WaitQueueWorkerCallback());
}
+ /**
+ * Sets the TaskExecutorService capacity to the new values. Both the number
of executors and the
+ * queue size should be smaller than that original values, so we do not mess
up with the other
+ * settings. Setting smaller capacity will not cancel or reject already
executing or queued tasks
+ * in itself.
+ * @param newNumExecutors The new number of executors
+ * @param newWaitQueueSize The new number of wait queue size
+ */
+ @Override
+ public synchronized void setCapacity(int newNumExecutors, int
newWaitQueueSize) {
+ if (newNumExecutors > configuredMaxExecutors) {
Review comment:
Added check and test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 266600)
Time Spent: 1h 10m (was: 1h)
> Add a new LlapDaemon Management API method to set the daemon capacity
> ---------------------------------------------------------------------
>
> Key: HIVE-21907
> URL: https://issues.apache.org/jira/browse/HIVE-21907
> Project: Hive
> Issue Type: Sub-task
> Components: llap
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21907.2.patch, HIVE-21907.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Add a new method to LlapManagementProtocol API which can disable an Llap node.
> It would be even better, if we can dynamically set the number of executors
> and the size of the wait queue. This way we can disable the node setting them
> to 0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
