[
https://issues.apache.org/jira/browse/HIVE-21762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863178#comment-16863178
]
Hive QA commented on HIVE-21762:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
53s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
48s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
55s{color} | {color:blue} standalone-metastore/metastore-common in master has
31 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
11s{color} | {color:blue} standalone-metastore/metastore-server in master has
184 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
20s{color} | {color:blue} ql in master has 2260 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
44s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
48s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
58s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
42s{color} | {color:red} ql: The patch generated 43 new + 240 unchanged - 19
fixed = 283 total (was 259) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
29s{color} | {color:red} ql generated 10 new + 2250 unchanged - 10 fixed = 2260
total (was 2260) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 12s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Write to static field
org.apache.hadoop.hive.ql.exec.repl.incremental.IncrementalLoadTasksBuilder.numIteration
from instance method new
org.apache.hadoop.hive.ql.exec.repl.incremental.IncrementalLoadTasksBuilder(String,
String, IncrementalLoadEventsIterator, HiveConf, Long) At
IncrementalLoadTasksBuilder.java:from instance method new
org.apache.hadoop.hive.ql.exec.repl.incremental.IncrementalLoadTasksBuilder(String,
String, IncrementalLoadEventsIterator, HiveConf, Long) At
IncrementalLoadTasksBuilder.java:[line 90] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser$DFA236 be a _static_
inner class? At HiveParser.java:inner class? At HiveParser.java:[lines
48232-48245] |
| | Dead store to LA31_128 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 47972] |
| | Dead store to LA31_130 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 47985] |
| | Dead store to LA31_132 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 47998] |
| | Dead store to LA31_134 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 48011] |
| | Dead store to LA31_136 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 48024] |
| | Dead store to LA31_138 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 48037] |
| | Dead store to LA31_140 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 48050] |
| | Dead store to LA31_142 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 48063] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17556/dev-support/hive-personality.sh
|
| git revision | master / 145aec9 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17556/yetus/diff-checkstyle-ql.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17556/yetus/new-findbugs-ql.html
|
| modules | C: standalone-metastore/metastore-common
standalone-metastore/metastore-server ql itests/hive-unit U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17556/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> REPL DUMP to support new format for replication policy input to take included
> tables list.
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-21762
> URL: https://issues.apache.org/jira/browse/HIVE-21762
> Project: Hive
> Issue Type: Sub-task
> Components: repl
> Reporter: Sankar Hariappan
> Assignee: Sankar Hariappan
> Priority: Major
> Labels: DR, Replication, pull-request-available
> Attachments: HIVE-21762.01.patch, HIVE-21762.02.patch,
> HIVE-21762.03.patch, HIVE-21762.04.patch, HIVE-21762.05.patch,
> HIVE-21762.06.patch, HIVE-21762.07.patch
>
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> - REPL DUMP syntax:
> {code}
> REPL DUMP <repl_policy> [FROM <last_repl_id> WITH <key_values_list>;
> {code}
> - New format for the Replication policy have 3 parts all separated with Dot
> (.).
> 1. First part is DB name.
> 2. Second part is included list. Comma separated table names/regex with in
> square brackets[]. If square brackets are not there, then it is treated as
> single table replication which skips DB level events.
> 3. Third part is excluded list. Comma separated table names/regex with in
> square brackets[].
> {code}
> <db_name> -- Full DB replication which is currently supported
> <db_name>.['.*?'] -- Full DB replication
> <db_name>.[] -- Replicate just functions and not include any tables.
> <db_name>.['t1', 't2'] -- DB replication with static list of tables t1 and
> t2 included.
> <db_name>.['t1*', 't2', '*t3'].['t100', '5t3', 't4'] -- DB replication with
> all tables having prefix t1, with suffix t3 and include table t2 and exclude
> t100 which has the prefix t1, 5t3 which suffix t3 and t4.
> {code}
> - Need to support regular expression of any format.
> - A table is included in dump only if it matches the regular expressions in
> included list and doesn't match the excluded list.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
