[ https://issues.apache.org/jira/browse/HIVE-21832?focusedWorklogId=256022&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-256022 ]
ASF GitHub Bot logged work on HIVE-21832: ----------------------------------------- Author: ASF GitHub Bot Created on: 07/Jun/19 16:16 Start Date: 07/Jun/19 16:16 Worklog Time Spent: 10m Work Description: pvary commented on pull request #665: HIVE-21832: New metrics to get the average queue/serving/response time URL: https://github.com/apache/hive/pull/665#discussion_r291661699 ########## File path: llap-server/src/java/org/apache/hadoop/hive/llap/metrics/LlapDaemonExecutorMetrics.java ########## @@ -195,14 +202,22 @@ private LlapDaemonExecutorMetrics(String displayName, JvmMetrics jm, String sess this.executorThreadUserTime[i] = registry.newGauge(miu, 0L); this.executorNames.put(ContainerRunnerImpl.THREAD_NAME_FORMAT_PREFIX + i, i); } + if (simpleAverageWindowDataSize > 0) { + this.queueTime = new SynchronizedDescriptiveStatistics(simpleAverageWindowDataSize); Review comment: The 2 new averages are updated in InternalCompletionListener.onSuccess callback which is running in a separate thread specifically to make sure that the other tasks are not rejected because of this: ` // Callback on a separate thread so that when a task completes, the thread in the main queue // is actually available for execution and will not potentially result in a RejectedExecution ` There is only one more place when these stats are accessed - Metrics collection, which should not cause problem either. Am I right when I think that this means that this will not cause issue for us until it is not used elsewhere? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 256022) Time Spent: 40m (was: 0.5h) > New metrics to get the average queue/serving/response time > ---------------------------------------------------------- > > Key: HIVE-21832 > URL: https://issues.apache.org/jira/browse/HIVE-21832 > Project: Hive > Issue Type: Sub-task > Components: llap > Reporter: Peter Vary > Assignee: Peter Vary > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21832.2.patch, HIVE-21832.patch > > Time Spent: 40m > Remaining Estimate: 0h > > Simple > [DescriptiveStatistics|https://commons.apache.org/proper/commons-math/javadocs/api-3.6/src-html/org/apache/commons/math3/stat/descriptive/DescriptiveStatistics.html#line.60] > with window size would do here. Time is not important in this case. -- This message was sent by Atlassian JIRA (v7.6.3#76005)