[
https://issues.apache.org/jira/browse/HIVE-21822?focusedWorklogId=254899&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254899
]
ASF GitHub Bot logged work on HIVE-21822:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/19 05:45
Start Date: 06/Jun/19 05:45
Worklog Time Spent: 10m
Work Description: pvary commented on issue #657: HIVE-21822: Expose
LlapDaemon metrics through a new API method
URL: https://github.com/apache/hive/pull/657#issuecomment-499356942
> Please consider, making the transfer of daemon metrics more generic,
instead of specific for two counters.
Created both implementations.
Run some tests on my local machine. My original fear that dumping all
metrics would be costly is not justified, both getDaemonMetrics (full dump),
and getLoadMetrics (dumping only 2 metrics) daemon API calls took around 300ms
on my own laptop. Measuring only generating the full list of metrics (72
element) have took around 10ms.
On the other hand there are several tools which can check the API backward
compatibility. For example we are using Java API Compliance Checker for
checking changes in Hive public API-s. AFAIK there are plans to connect to the
LLAP daemons from other projects than Hive, so I think we should consider LLAP
daemon API as a public API too. These tools can not check the content of the
maps this is why I think that we should specifically define the values we would
like to build upon on other components.
You might have better / more information on how we plan to use the API-s in
the future, so I am open to any suggestions.
Thanks,
Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 254899)
Time Spent: 40m (was: 0.5h)
> Expose LlapDaemon metrics through a new API method
> --------------------------------------------------
>
> Key: HIVE-21822
> URL: https://issues.apache.org/jira/browse/HIVE-21822
> Project: Hive
> Issue Type: Sub-task
> Components: llap
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21822.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We should add a new API method to access specific LlapDaemon metrics which
> would provide information to TezAMs to make good decisions on load balancing
> tasks
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
