[ 
https://issues.apache.org/jira/browse/HIVE-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693112#comment-14693112
 ] 

Amareshwari Sriramadasu commented on HIVE-11483:
------------------------------------------------

Thanks [~alangates] for you comments.

bq. Do we need the query string in the config at all? What on the backend reads 
it?
Right now, the usage in hive is to set the query on the conf(which goes in 
xml), and is used for logging the query in PRE and POST exec hooks. 

bq. One issue with this is it makes the query string not human readable.
Agree. But there are options to use online base64 decoders if user really want 
to. We can look at other options for encoding instead of Base64 like URL 
encoding.

bq.  If we want to preserve this should we instead just mask the control 
characters (ie change actual ctrl-A to ^A or something)
How do we distinguish between actual ^A with control-A ? And how to decode them 
back.

> Add encoding and decoding for query string config
> -------------------------------------------------
>
>                 Key: HIVE-11483
>                 URL: https://issues.apache.org/jira/browse/HIVE-11483
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Amareshwari Sriramadasu
>
> We have seen some queries in production where some of the literals passed in 
> the query have control characters, which result in exception when query 
> string is set in the job xml.
> Proposing a solution to encode the query string in configuration and provide 
> getters decoded string.
> Here is a commit in a forked repo : 
> https://github.com/InMobi/hive/commit/2faf5761191fa3103a0d779fde584d494ed75bf5
> Suggestions are welcome on the solution.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to