[
https://issues.apache.org/jira/browse/HIVE-21740?focusedWorklogId=248813&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-248813
]
ASF GitHub Bot logged work on HIVE-21740:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/19 12:50
Start Date: 27/May/19 12:50
Worklog Time Spent: 10m
Work Description: pvary commented on pull request #633: HIVE-21740:
Collect LLAP execution latency metrics
URL: https://github.com/apache/hive/pull/633#discussion_r287778469
##########
File path:
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapTaskSchedulerMetrics.java
##########
@@ -276,6 +302,43 @@ private void getTaskSchedulerStats(MetricsRecordBuilder
rb) {
.addCounter(SchedulerPendingPreemptionTaskCount,
pendingPreemptionTasksCount.value())
.addCounter(SchedulerPreemptedTaskCount, preemptedTasksCount.value())
.addCounter(SchedulerCompletedDagCount, completedDagcount.value());
+ daemonTaskLatency.forEach((k, v) -> rb.addGauge(v, v.getMean()));
+ }
+
+ static class DaemonLatencyMetric implements MetricsInfo {
+ private String name;
+ private ExponentiallyDecayingReservoir reservoir;
Review comment:
Do not like Guava, and Stats appeared in guava 20. We are on 19 now and
upgrading can cause problems with other projects like hadoop.
Moved to using apache math DescriptiveStatistics instead.
Also moved to simple windowing average instead of DecayMetrics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 248813)
Time Spent: 3h (was: 2h 50m)
> Collect LLAP execution latency metrics
> --------------------------------------
>
> Key: HIVE-21740
> URL: https://issues.apache.org/jira/browse/HIVE-21740
> Project: Hive
> Issue Type: New Feature
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21740.2.patch, HIVE-21740.patch
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Collect metrics for LLAP task execution times
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
