[ 
https://issues.apache.org/jira/browse/HIVE-21713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848691#comment-16848691
 ] 

Manoj Narayanan commented on HIVE-21713:
----------------------------------------

[~kgyrtkirk] I assume you are referring to changing the name given here, 

[https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java#L35].

 

I assume it must be a straight forward change. But I had a few questions,

it seems at least some of  Explain classes are named as Operator. I did a code 
search and 66 classes had named as Operator out of total 600 odd ones.  Only 1 
of them had Task in the name. If that is the case, is it a convention to have 
Operator in the name ? So is it OK to continue to name it as 'Move Operator' ? 
Just wanted to confirm before proceeding with a  patch. 

find . -name \*.java | grep -v Test | xargs grep  @Explain | grep display | 
grep -i operator | wc -l

      66

find . -name \*.java | grep -v Test | xargs grep  @Explain | grep display | wc 
-l

     641

find . -name \*.java | grep -v Test | xargs grep  @Explain | grep display | 
grep -i task |wc -l

       2

 

> Explain consistency Task/Operator
> ---------------------------------
>
>                 Key: HIVE-21713
>                 URL: https://issues.apache.org/jira/browse/HIVE-21713
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Priority: Major
>
> there seems to be some inconsistency what gets printed in the explain;
> for example "MoveTask" is shown as "Move Operator" in the explain
> Becase Tasks and Operators are basically different things - this should be 
> corrected as it may cause confusion



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to