[ https://issues.apache.org/jira/browse/HIVE-21753?focusedWorklogId=248405&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-248405 ]
ASF GitHub Bot logged work on HIVE-21753: ----------------------------------------- Author: ASF GitHub Bot Created on: 25/May/19 06:41 Start Date: 25/May/19 06:41 Worklog Time Spent: 10m Work Description: rameeshm commented on pull request #644: HIVE-21753: Update HiveMetastore authorization to enable use of HiveA… URL: https://github.com/apache/hive/pull/644#discussion_r287553336 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ########## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.hadoop.hive.ql.security.authorization.plugin.metastore; + +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.metastore.HiveMetaStore; +import org.apache.hadoop.hive.metastore.MetaStorePreEventListener; +import org.apache.hadoop.hive.metastore.TableType; +import org.apache.hadoop.hive.metastore.api.InvalidOperationException; +import org.apache.hadoop.hive.metastore.api.MetaException; +import org.apache.hadoop.hive.metastore.api.NoSuchObjectException; +import org.apache.hadoop.hive.metastore.api.Table; +import org.apache.hadoop.hive.metastore.events.PreAlterTableEvent; +import org.apache.hadoop.hive.metastore.events.PreCreateTableEvent; +import org.apache.hadoop.hive.metastore.events.PreDropTableEvent; +import org.apache.hadoop.hive.metastore.events.PreEventContext; +import org.apache.hadoop.hive.metastore.utils.MetaStoreServerUtils; +import org.apache.hadoop.hive.ql.metadata.HiveException; +import org.apache.hadoop.hive.ql.metadata.HiveUtils; +import org.apache.hadoop.hive.ql.security.HiveMetastoreAuthenticationProvider; +import org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.events.*; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAuthorizer; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAuthorizerFactory; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAuthzContext; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAuthzSessionContext; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveMetastoreClientFactoryImpl; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveOperationType; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HivePrivilegeObject; +import org.apache.hadoop.security.UserGroupInformation; + +import java.util.List; + +/** + * HiveMetaStoreAuthorizer : Do authorization checks on MetaStore Events in MetaStorePreEventListener + */ + +public class HiveMetaStoreAuthorizer extends MetaStorePreEventListener { + private static final Log LOG = LogFactory.getLog(HiveMetaStoreAuthorizer.class); + private static PreEventContext preEventContext = null; + + private static final ThreadLocal<Configuration> tConfig = new ThreadLocal<Configuration>() { + @Override + protected Configuration initialValue() { + return new HiveConf(HiveMetaStoreAuthorizer.class); + } + }; + + private static final ThreadLocal<HiveMetastoreAuthenticationProvider> tAuthenticator = new ThreadLocal<HiveMetastoreAuthenticationProvider>() { + @Override + protected HiveMetastoreAuthenticationProvider initialValue() { Review comment: resolved this issue ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 248405) Time Spent: 3h 50m (was: 3h 40m) > Update HiveMetastore authorization to enable use of HiveAuthorizer > implementation > --------------------------------------------------------------------------------- > > Key: HIVE-21753 > URL: https://issues.apache.org/jira/browse/HIVE-21753 > Project: Hive > Issue Type: Bug > Components: Hive > Affects Versions: 3.1.2 > Reporter: Ramesh Mani > Assignee: Ramesh Mani > Priority: Critical > Labels: pull-request-available > Attachments: HIVE-21753.1.patch, HIVE-21753.2.patch > > Time Spent: 3h 50m > Remaining Estimate: 0h > > Currently HMS supports authorization using StorageBasedAuthorizationProvider > which relies on permissions at filesystem – like HDFS. Hive supports a > pluggable authorization interface, and multiple authorizer implementations > (like SQLStd, Ranger, Sentry) are available to authorizer access in Hive. > Extending HiveMetastore to use the same authorization interface as Hive will > enable use of pluggable authorization implementations; and will result in > consistent authorization across Hive, HMS and other services that use HMS > (like Spark). -- This message was sent by Atlassian JIRA (v7.6.3#76005)