[
https://issues.apache.org/jira/browse/HIVE-21776?focusedWorklogId=247873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-247873
]
ASF GitHub Bot logged work on HIVE-21776:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/19 04:43
Start Date: 24/May/19 04:43
Worklog Time Spent: 10m
Work Description: ashutosh-bapat commented on pull request #642:
HIVE-21776 : Replication fails to replicate a UDF with jar on HDFS during
incremental
URL: https://github.com/apache/hive/pull/642#discussion_r287213878
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java
##########
@@ -356,6 +356,9 @@ public static FileInfo getFileInfo(Path src, String
checksumString, String srcCM
// Currently using fileuri#checksum#cmrooturi#subdirs as the format
public static String encodeFileUri(String fileUriStr, String fileChecksum,
String encodedSubDir)
throws IOException {
+ if (instance == null) {
Review comment:
assert may not trigger in production and we won't catch the problem in REPL
DUMP itself. The problem will be seen only in REPL LOAD, and that too with no
clue as to what went wrong. So, it's better to have an exception.
IllegalStateException is better. Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 247873)
Time Spent: 40m (was: 0.5h)
> Replication fails to replicate a UDF with jar on HDFS during incremental
> ------------------------------------------------------------------------
>
> Key: HIVE-21776
> URL: https://issues.apache.org/jira/browse/HIVE-21776
> Project: Hive
> Issue Type: Bug
> Affects Versions: 4.0.0
> Reporter: Ashutosh Bapat
> Assignee: Ashutosh Bapat
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21776.01.patch, HIVE-21776.02.patch,
> HIVE-21776.03.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> TestReplicationScenariosAcrossInstances has test to test bootstrap of a UDF
> with jar on HDFS but no test for incremental. Add the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
