[ 
https://issues.apache.org/jira/browse/HIVE-21732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845949#comment-16845949
 ] 

slim bouguerra commented on HIVE-21732:
---------------------------------------

looks good to me there is a minor comments that is to consider for the future 
please use illegal argument exceptions for cases like 

{code}

 if (threshold < 0 || threshold > 1.0) {
              throw new 
RuntimeException(HiveConf.ConfVars.HIVE_TEST_LOAD_UTILIZATION.varname + " 
should " +
                "be between 0.0 and 1.0. The configuration specified [" + 
threshold + "]");
 }

{code}

> Configurable injection of load for LLAP task execution
> ------------------------------------------------------
>
>                 Key: HIVE-21732
>                 URL: https://issues.apache.org/jira/browse/HIVE-21732
>             Project: Hive
>          Issue Type: Test
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21732.2.patch, HIVE-21732.3.patch, 
> HIVE-21732.4.patch, HIVE-21732.5.patch, HIVE-21732.6.patch, 
> HIVE-21732.7.patch, HIVE-21732.8.patch, HIVE-21732.patch
>
>          Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> For evaluating testing, it would be good to have a configurable way to inject 
> latency for LLAP tasks.
> The configuration should be able to control how much latency is injected into 
> each daemon.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to