[
https://issues.apache.org/jira/browse/HIVE-21753?focusedWorklogId=245779&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-245779
]
ASF GitHub Bot logged work on HIVE-21753:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/19 06:40
Start Date: 21/May/19 06:40
Worklog Time Spent: 10m
Work Description: daijyc commented on pull request #636: HIVE-21753:
Update HiveMetastore authorization to enable use of HiveA…
URL: https://github.com/apache/hive/pull/636#discussion_r285861618
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
##########
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.hadoop.hive.ql.security.authorization.plugin.metastore;
+
+import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.MetaStorePreEventListener;
+import org.apache.hadoop.hive.metastore.api.InvalidOperationException;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.NoSuchObjectException;
+import org.apache.hadoop.hive.metastore.events.PreEventContext;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.apache.hadoop.hive.ql.metadata.HiveUtils;
+import org.apache.hadoop.hive.ql.security.HiveMetastoreAuthenticationProvider;
+import
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.events.*;
+import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAuthorizer;
+import
org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAuthorizerFactory;
+import
org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAuthzContext;
+import
org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAuthzSessionContext;
+import
org.apache.hadoop.hive.ql.security.authorization.plugin.HiveMetastoreClientFactoryImpl;
+import
org.apache.hadoop.hive.ql.security.authorization.plugin.HiveOperationType;
+import
org.apache.hadoop.hive.ql.security.authorization.plugin.HivePrivilegeObject;
+import org.apache.hadoop.security.UserGroupInformation;
+
+import java.util.List;
+
+/**
+ * HiveMetaStoreAuthorizer : Do authorization checks on MetaStore Events in
MetaStorePreEventListener
+ */
+
+public class HiveMetaStoreAuthorizer extends MetaStorePreEventListener {
+ private static final Log LOG =
LogFactory.getLog(HiveMetaStoreAuthorizer.class);
+ private static final String HIVE_SUPER_USERS =
"hive.metastore.authorization.superusers";
+ private static PreEventContext preEventContext = null;
+
+ private String[] superUsers = null;
+
+ private static final ThreadLocal<Configuration> tConfig = new
ThreadLocal<Configuration>() {
+ @Override
+ protected Configuration initialValue() {
+ return new HiveConf(HiveMetaStoreAuthorizer.class);
+ }
+ };
+
+ private static final ThreadLocal<HiveMetastoreAuthenticationProvider>
tAuthenticator = new ThreadLocal<HiveMetastoreAuthenticationProvider>() {
+ @Override
+ protected HiveMetastoreAuthenticationProvider initialValue() {
+ try {
+ return (HiveMetastoreAuthenticationProvider)
HiveUtils.getAuthenticator(tConfig.get(),
HiveConf.ConfVars.HIVE_METASTORE_AUTHENTICATOR_MANAGER);
+ } catch (HiveException excp) {
+ throw new IllegalStateException("Authentication provider instantiation
failure", excp);
+ }
+ }
+ };
+
+ public static synchronized PreEventContext getPreEventContext() {
+ return preEventContext;
+ }
+ public HiveMetaStoreAuthorizer(Configuration config) {
+ super(config);
+ superUsers = config.getStrings(HIVE_SUPER_USERS);
+ }
+
+ @Override
+ public final void onEvent(PreEventContext preEventContext) throws
MetaException, NoSuchObjectException, InvalidOperationException {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("==> HiveMetaStoreAuthorizer.onEvent(): EventType=" +
preEventContext.getEventType());
+ }
+
+ HiveMetaStoreAuthzInfo authzContext = buildAuthzContext(preEventContext);
+
+ if (!skipAuthorization(authzContext)) {
+ try {
+ HiveConf hiveConf = new HiveConf(super.getConf(),
HiveConf.class);
+ HiveAuthorizerFactory authorizerFactory =
HiveUtils.getAuthorizerFactory(hiveConf,
HiveConf.ConfVars.HIVE_AUTHORIZATION_MANAGER);
+
+ if (authorizerFactory != null) {
+ HiveMetastoreAuthenticationProvider authenticator =
tAuthenticator.get();
+
+ authenticator.setConf(hiveConf);
+
+ HiveAuthzSessionContext.Builder authzContextBuilder = new
HiveAuthzSessionContext.Builder();
+
+
authzContextBuilder.setClientType(HiveAuthzSessionContext.CLIENT_TYPE.HIVECLI);
+ authzContextBuilder.setSessionString("HiveMetaStore");
+
+ HiveAuthzSessionContext authzSessionContext =
authzContextBuilder.build();
+
+ HiveAuthorizer hiveAuthorizer =
authorizerFactory.createHiveAuthorizer(new HiveMetastoreClientFactoryImpl(),
hiveConf, authenticator, authzSessionContext);
+
+ authenticator.getUserName();
+
+ checkPrivileges(authzContext, hiveAuthorizer);
+ }
+ } catch (HiveException e) {
+ LOG.error("HiveMetaStoreAuthorizer.onEvent(): failed", e);
+ }
+ }
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("<== HiveMetaStoreAuthorizer.onEvent(): EventType=" +
preEventContext.getEventType());
+ }
+ }
+
+
+ private HiveMetaStoreAuthzInfo buildAuthzContext(PreEventContext
preEventContext) throws MetaException {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("==> HiveMetaStoreAuthorizer.buildAuthzContext(): EventType="
+ preEventContext.getEventType());
+ }
+
+ HiveMetaStoreAuthorizableEvent authzEvent = null;
+
+ if (preEventContext != null) {
+ this.preEventContext = preEventContext;
+ switch (preEventContext.getEventType()) {
+ case CREATE_DATABASE:
Review comment:
There are missing events need handling, some of those also require invoking
preListener in HiveMetaStore.java
1. create catalog, alter catalog, drop catalog*, admin only
2. drop constrain*, add primary key/foreign key/unique key/not
null/default/check constraint*, these require alter table privs
3. exchange partition*, require alter partition privs
4. update/delete table column stats*, require alter table privs
5. update/delete partition column stats*, require alter partition privs
6. create/drop/alter function*, require function privs (if there's any)
7. schema registry related event: add/alter/drop schema, add serde, maybe we
can skip for now, but need to track for the future
8. all auth related events: PreAuthorizationCallEvent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 245779)
Time Spent: 0.5h (was: 20m)
> Update HiveMetastore authorization to enable use of HiveAuthorizer
> implementation
> ---------------------------------------------------------------------------------
>
> Key: HIVE-21753
> URL: https://issues.apache.org/jira/browse/HIVE-21753
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Affects Versions: 3.1.2
> Reporter: Ramesh Mani
> Assignee: Ramesh Mani
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently HMS supports authorization using StorageBasedAuthorizationProvider
> which relies on permissions at filesystem – like HDFS. Hive supports a
> pluggable authorization interface, and multiple authorizer implementations
> (like SQLStd, Ranger, Sentry) are available to authorizer access in Hive.
> Extending HiveMetastore to use the same authorization interface as Hive will
> enable use of pluggable authorization implementations; and will result in
> consistent authorization across Hive, HMS and other services that use HMS
> (like Spark).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
